FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adjust chart vars · Issue #2011 · patternfly/patternfly · GitHub

Adjust chart vars #2011

Description

  1. $pf-chart-axis--tick--Width should be 5 -- can't see axis ticks with a value of 1

  2. $pf-chart-axis--grid--stroke--Color, and $pf-chart-axis--tick--stroke--Color are 'transparent'. We need to define colors here in order to show axis ticks.

  3. $pf-chart-axis--grid--Fill is 'transparent', but probably should be 'none'? Transparent seems to work, but material.js and greyscale.js both use 'none'.

  4. $pf-chart-pie--angle--Padding is 1. We don't use angle padding with the standard pie chart. If we want to keep a var for this, it should be zero or we can just remove it?

  5. $pf-chart-global--stroke-dash-array is '10, 5'. This makes the grid lines look like dashes. I believe we want solid grid lines, so I removed it.

  6. $pf-chart-chart--BorderWidth is used as a border around the entire SVG, not the chart itself. It didn't work as expected, so I've removed it.

  7. These vars ended up being unused:

$pf-chart-pie--small--Height,
$pf-chart-pie--small--Width,
$pf-chart-donut--threshold--success--Color,
$pf-chart-donut--utilization--label--subtitle--Fill
$pf-chart-donut--utilization--label--orientation
$pf-chart-tooltip--labels--Padding << we're using chart_tooltip_pointer_length
$pf-chart-tooltip--labels--PointerEvents
$pf-chart-tooltip--pointer--Height
  1. Would like to have new vars for:

$pf-chart-legend--position: right
$pf-chart-donut--label--subtitle--position: center

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions


Back | FazBrowse Home | New Git URL