FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(LoginPage): Convert LoginPage to typescript, add integration tes… · patternfly/patternfly-react@83debda · GitHub

/ patternfly-react Public

Commit 83debda

Browse files
jeff-phillips-18
committed
feat(LoginPage): Convert LoginPage to typescript, add integration tests and demo
1 parent c92e603 commit 83debda

70 files changed

Lines changed: 920 additions & 799 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎packages/patternfly-4/react-core/src/components/Form/FormHelperText.d.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import { FunctionComponent, HTMLProps, ReactNode } from 'react';
33
export interface FormHelperTextProps extends HTMLProps<HTMLDivElement> {
44
children?: ReactNode;
55
isError?: boolean;
6-
isActive?: boolean;
6+
isHidden?: boolean;
77
className?: string;
88
}
99

1010
declare const FormHelperText: FunctionComponent<FormHelperTextProps>;
1111

12-
export default FormHelperText;
12+
export default FormHelperText;

‎packages/patternfly-4/react-core/src/components/LoginPage/Login.d.ts‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

packages/patternfly-4/react-core/src/components/LoginPage/Login.test.js renamed to packages/patternfly-4/react-core/src/components/LoginPage/Login.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react';
1+
import * as React from 'react';
22
import { shallow } from 'enzyme';
33
import Login from './Login';
44
import LoginFooter from './LoginFooter';

packages/patternfly-4/react-core/src/components/LoginPage/Login.js renamed to packages/patternfly-4/react-core/src/components/LoginPage/Login.tsx

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,25 @@
1-
import React from 'react';
1+
import * as React from 'react';
22
import styles from '@patternfly/patternfly/components/Login/login.css';
33
import { css } from '@patternfly/react-styles';
4-
import PropTypes from 'prop-types';
54

6-
const propTypes = {
5+
export interface LoginProps extends React.HTMLProps<HTMLDivElement> {
76
/** Content rendered inside the main section of the login layout */
8-
children: PropTypes.node,
7+
children?: React.ReactNode;
98
/** Additional classes added to the login layout */
10-
className: PropTypes.string,
9+
className?: string;
1110
/** Footer component (e.g. <LoginFooter />) */
12-
footer: PropTypes.node,
11+
footer?: React.ReactNode;
1312
/** Header component (e.g. <LoginHeader />) */
14-
header: PropTypes.node,
15-
/** Additional props are spread to the container <div> */
16-
'': PropTypes.any
17-
};
13+
header?: React.ReactNode;
14+
}
1815

19-
const defaultProps = {
20-
children: null,
21-
className: '',
22-
footer: null,
23-
header: null
24-
};
25-
26-
const Login = ({ className, children, footer, header, ...props }) => (
16+
export const Login: React.FunctionComponent<LoginProps> = ({
17+
className = '',
18+
children = null,
19+
footer = null,
20+
header = null,
21+
...props
22+
}) => (
2723
<div {...props} className={css(styles.login, className)}>
2824
<div className={css(styles.loginContainer)}>
2925
{header}
@@ -33,7 +29,4 @@ const Login = ({ className, children, footer, header, ...props }) => (
3329
</div>
3430
);
3531

36-
Login.propTypes = propTypes;
37-
Login.defaultProps = defaultProps;
38-
3932
export default Login;

‎packages/patternfly-4/react-core/src/components/LoginPage/LoginFooter.d.ts‎

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎packages/patternfly-4/react-core/src/components/LoginPage/LoginFooter.js‎

Lines changed: 0 additions & 29 deletions
This file was deleted.

‎packages/patternfly-4/react-core/src/components/LoginPage/LoginFooter.tsx‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
import * as React from 'react';
2+
import styles from '@patternfly/patternfly/components/Login/login.css';
3+
import { css } from '@patternfly/react-styles';
4+
5+
export interface LoginFooterProps extends React.HTMLProps<HTMLElement> {
6+
/** Content rendered inside the footer of the login layout */
7+
children?: React.ReactNode;
8+
/** Additional props are spread to the container <footer> */
9+
className?: string;
10+
}
11+
12+
export const LoginFooter: React.FunctionComponent<LoginFooterProps> = ({
13+
className = '',
14+
children = null,
15+
...props
16+
}) => (
17+
<footer className={css(styles.loginFooter, className)} {...props}>
18+
{children}
19+
</footer>
20+
);
21+
22+
export default LoginFooter;

‎packages/patternfly-4/react-core/src/components/LoginPage/LoginFooterItem.d.ts‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎packages/patternfly-4/react-core/src/components/LoginPage/LoginFooterItem.js‎

Lines changed: 0 additions & 38 deletions
This file was deleted.

packages/patternfly-4/react-core/src/components/LoginPage/LoginFooterItem.test.js renamed to packages/patternfly-4/react-core/src/components/LoginPage/LoginFooterItem.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react';
1+
import * as React from 'react';
22
import LoginFooterItem from './LoginFooterItem';
33
import { shallow } from 'enzyme';
44

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL