FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PF4 Switch label props breaking change · Issue #2600 · patternfly/patternfly-react · GitHub

PF4 Switch label props breaking change #2600

Description

A follow up to #2468 - to match the implementation to PF4 core the current API should be changed to include the label when the toggle is off and a different label when the toggle is on.

To solve this two ways come to mind:

  • update the type of label from string to string[2] where the first item is the label on on and the second one is on off
  • create two props labelOn and labelOff for the on and off states respectively.

This is going to be breaking change as it changes the API of the switch component.

//cc @jgiardino

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


    Back | FazBrowse Home | New Git URL