fix: remove heading autolinks and duplicate index nav items · patternfly-java/patternfly-java@0f80b0f · GitHub

patternfly-java / patternfly-java Public

• Notifications You must be signed in to change notification settings
• Fork 5
• Star 34

• Code
• Issues 39
• Pull requests 2
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0f80b0f

Browse filesBrowse the repository at this point in the historyBrowse files

hpehl

committed

fix: remove heading autolinks and duplicate index nav items

Remove rehype-autolink-headings plugin so markdown headers are plain text instead of clickable links. Remove the separate index navigation item from folder groups — the route is still registered but the duplicate "Concepts" child item under the "Concepts" group is gone.

1 parent 600ae56 commit 0f80b0f
Copy full SHA for 0f80b0f

2 files changed

+3-8Lines changed: 3 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• showcase
  • markdown.mjs
  • src/main/java/org/patternfly/showcase
    • MarkdownManifest.java

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎showcase/markdown.mjs‎

Copy file name to clipboardExpand all lines: showcase/markdown.mjs

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -21,7 +21,7 @@ import remarkGfm from 'remark-gfm';
21	21	import remarkFrontmatter from 'remark-frontmatter';
22	22	import remarkRehype from 'remark-rehype';
23	23	import rehypeSlug from 'rehype-slug';
24		- import rehypeAutolinkHeadings from 'rehype-autolink-headings';
	24	+
25	25	import rehypeShiki from '@shikijs/rehype';
26	26	import rehypeStringify from 'rehype-stringify';
27	27	import YAML from 'yaml';
@@ -94,7 +94,6 @@ async function createProcessor() {
94	94	.use(extractToc)
95	95	.use(remarkRehype, {allowDangerousHtml: true})
96	96	.use(rehypeSlug)
97		- .use(rehypeAutolinkHeadings, {behavior: 'wrap'})
98	97	.use(addHeadingClasses)
99	98	.use(rehypeShiki, {
100	99	theme: 'github-light',

Collapse file

‎showcase/src/main/java/org/patternfly/showcase/MarkdownManifest.java‎

Copy file name to clipboardExpand all lines: showcase/src/main/java/org/patternfly/showcase/MarkdownManifest.java

+2-6Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -30,7 +30,7 @@
30	30
31	31	import static elemental2.dom.DomGlobal.fetch;
32	32	import static org.jboss.elemento.router.Place.place;
33		- import static org.jboss.elemento.router.Places.places;
	33	+
34	34	import static org.patternfly.component.navigation.ExpandableNavigationGroup.expandableNavigationGroup;
35	35	import static org.patternfly.component.navigation.NavigationItem.navigationItem;
36	36
@@ -70,7 +70,7 @@ private void indexItems(ManifestItem[] items) {
70	70	// ------------------------------------------------------ places
71	71
72	72	public Places places() {
73		- Places allPlaces = places();
	73	+ Places allPlaces = Places.places();
74	74	addPlaces(allPlaces, items);
75	75	return allPlaces;
76	76	}
@@ -115,10 +115,6 @@ public org.patternfly.component.navigation.ExpandableNavigationGroup navGroup(Pl
115	115	}
116	116	org.patternfly.component.navigation.ExpandableNavigationGroup navGroup =
117	117	expandableNavigationGroup(group.id, group.title);
118		- if (group.hasContent) {
119		- Place place = pm.place(group.route);
120		- navGroup.addItem(navigationItem(place.route, place.title, place.route));
121		- }
122	118	if (group.children != null) {
123	119	for (ManifestItem child : group.children) {
124	120	if ("page".equals(child.type)) {

0 commit comments

Comments

0 (0)