Commit 1842773
committed
fix: use correct toggle icons to match PatternFly
Replace rhUi.caretRight with rhMicrons.caretDown for all expandable
toggle icons (alert, card, data list, expandable section, form field
group, jump links, overflow tab, tabs toggle) to match PatternFly's
RhMicronsCaretDownIcon. Fix breadcrumb divider to use rhMicrons icon set.1 parent e8f166e commit 1842773
10 files changed
Lines changed: 22 additions & 17 deletions
File tree
- components/src/main/java/org/patternfly/component
- alert
- breadcrumb
- card
- expandable
- form
- jumplinks
- list
- tabs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| 6 | 6 | ||
| 7 | 7 | ## [Unreleased] | |
| 8 | 8 | ||
| 9 | + ### Fixed | ||
| 10 | + | ||
| 11 | + - Fix toggle icons across expandable components to use `rhMicrons.caretDown` instead of `rhUi.caretRight`, matching PatternFly's `RhMicronsCaretDownIcon` (alert, card, data list, expandable section, form field group, jump links, overflow tab, tabs toggle) | ||
| 12 | + - Fix breadcrumb divider icon to use `rhMicrons.caretRight` instead of `rhUi.caretRight` | ||
| 13 | + | ||
| 9 | 14 | ## [0.9.3] - 2026-07-05 | |
| 10 | 15 | ||
| 11 | 16 | ### Added | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -69,7 +69,7 @@ | |||
| 69 | 69 | import static org.patternfly.core.Aria.live; | |
| 70 | 70 | import static org.patternfly.handler.CloseHandler.fireEvent; | |
| 71 | 71 | import static org.patternfly.handler.CloseHandler.shouldClose; | |
| 72 | - import static org.patternfly.icon.IconSets.rhUi.caretRight; | ||
| 72 | + import static org.patternfly.icon.IconSets.rhMicrons.caretDown; | ||
| 73 | 73 | import static org.patternfly.style.Classes.alert; | |
| 74 | 74 | import static org.patternfly.style.Classes.component; | |
| 75 | 75 | import static org.patternfly.style.Classes.icon; | |
@@ -233,7 +233,7 @@ public Alert expandable(ToggleHandler<Alert> toggleHandler) { | |||
| 233 | 233 | .aria(expanded, false) | |
| 234 | 234 | .aria(label, severity.name() + " alert: " + title + " details") | |
| 235 | 235 | .add(span().css(component(alert, toggle, icon)) | |
| 236 | - .add(caretRight().element()))) | ||
| 236 | + .add(caretDown().element()))) | ||
| 237 | 237 | .element()); | |
| 238 | 238 | this.expandable = true; | |
| 239 | 239 | this.toggleHandler = toggleHandler; | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -35,7 +35,7 @@ | |||
| 35 | 35 | import static org.jboss.elemento.Elements.li; | |
| 36 | 36 | import static org.jboss.elemento.Elements.span; | |
| 37 | 37 | import static org.jboss.elemento.EventType.click; | |
| 38 | - import static org.patternfly.icon.IconSets.rhUi.caretRight; | ||
| 38 | + import static org.patternfly.icon.IconSets.rhMicrons.caretRight; | ||
| 39 | 39 | import static org.patternfly.style.Classes.breadcrumb; | |
| 40 | 40 | import static org.patternfly.style.Classes.component; | |
| 41 | 41 | import static org.patternfly.style.Classes.divider; | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -34,7 +34,7 @@ | |||
| 34 | 34 | import static org.jboss.elemento.EventType.click; | |
| 35 | 35 | import static org.patternfly.component.button.Button.button; | |
| 36 | 36 | import static org.patternfly.core.Aria.expanded; | |
| 37 | - import static org.patternfly.icon.IconSets.rhUi.caretRight; | ||
| 37 | + import static org.patternfly.icon.IconSets.rhMicrons.caretDown; | ||
| 38 | 38 | import static org.patternfly.style.Classes.component; | |
| 39 | 39 | import static org.patternfly.style.Classes.header; | |
| 40 | 40 | import static org.patternfly.style.Classes.icon; | |
@@ -102,7 +102,7 @@ public void attach(MutationRecord mutationRecord) { | |||
| 102 | 102 | }) | |
| 103 | 103 | .on(click, e -> card.toggle()) | |
| 104 | 104 | .add(span().css(component(Classes.card, header, toggle, icon)) | |
| 105 | - .add(caretRight().element()))) | ||
| 105 | + .add(caretDown().element()))) | ||
| 106 | 106 | .element(); | |
| 107 | 107 | if (card.toggleRightAligned) { | |
| 108 | 108 | css(modifier(toggleRight)); | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -29,7 +29,7 @@ | |||
| 29 | 29 | import static org.patternfly.component.IconPosition.start; | |
| 30 | 30 | import static org.patternfly.component.button.Button.button; | |
| 31 | 31 | import static org.patternfly.core.Aria.expanded; | |
| 32 | - import static org.patternfly.icon.IconSets.rhUi.caretRight; | ||
| 32 | + import static org.patternfly.icon.IconSets.rhMicrons.caretDown; | ||
| 33 | 33 | import static org.patternfly.style.Classes.component; | |
| 34 | 34 | import static org.patternfly.style.Classes.expandTop; | |
| 35 | 35 | import static org.patternfly.style.Classes.expandableSection; | |
@@ -85,7 +85,7 @@ <E extends HTMLElement> ExpandableSectionToggle(HTMLContainerBuilder<E> builder, | |||
| 85 | 85 | this.moreText = moreText; | |
| 86 | 86 | this.lessText = lessText; | |
| 87 | 87 | this.iconContainer = span().css(component(expandableSection, toggle, icon)) | |
| 88 | - .add(caretRight()) | ||
| 88 | + .add(caretDown()) | ||
| 89 | 89 | .element(); | |
| 90 | 90 | this.button = button() | |
| 91 | 91 | .link() | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -40,7 +40,7 @@ | |||
| 40 | 40 | import static org.patternfly.core.Aria.labelledBy; | |
| 41 | 41 | import static org.patternfly.core.Attributes.role; | |
| 42 | 42 | import static org.patternfly.core.Roles.group; | |
| 43 | - import static org.patternfly.icon.IconSets.rhUi.caretRight; | ||
| 43 | + import static org.patternfly.icon.IconSets.rhMicrons.caretDown; | ||
| 44 | 44 | import static org.patternfly.style.Classes.component; | |
| 45 | 45 | import static org.patternfly.style.Classes.fieldGroup; | |
| 46 | 46 | import static org.patternfly.style.Classes.form; | |
@@ -141,7 +141,7 @@ public FormFieldGroup expandable(ToggleHandler<FormFieldGroup> toggleHandler) { | |||
| 141 | 141 | .aria(label, "Details") | |
| 142 | 142 | .aria(labelledBy, titleId + " " + toggleId) | |
| 143 | 143 | .add(span().css(component(form, fieldGroup, toggle, icon)) | |
| 144 | - .add(caretRight())))) | ||
| 144 | + .add(caretDown())))) | ||
| 145 | 145 | .element()); | |
| 146 | 146 | } | |
| 147 | 147 | this.expandable = true; | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -63,7 +63,7 @@ | |||
| 63 | 63 | import static org.patternfly.component.button.Button.button; | |
| 64 | 64 | import static org.patternfly.core.Aria.expanded; | |
| 65 | 65 | import static org.patternfly.core.Attributes.role; | |
| 66 | - import static org.patternfly.icon.IconSets.rhUi.caretRight; | ||
| 66 | + import static org.patternfly.icon.IconSets.rhMicrons.caretDown; | ||
| 67 | 67 | import static org.patternfly.style.Breakpoint.default_; | |
| 68 | 68 | import static org.patternfly.style.Breakpoints.breakpoints; | |
| 69 | 69 | import static org.patternfly.style.Classes.component; | |
@@ -387,7 +387,7 @@ private Button failSafeToggleButton() { | |||
| 387 | 387 | .aria(Aria.label, "Toggle jump links") | |
| 388 | 388 | .on(click, e -> toggle()) | |
| 389 | 389 | .add(span().css(component(jumpLinks, toggle, icon)) | |
| 390 | - .add(caretRight())) | ||
| 390 | + .add(caretDown())) | ||
| 391 | 391 | .add(toggleTextElement = span().css(component(jumpLinks, toggle, text)) | |
| 392 | 392 | .text(labelElement.element().textContent)))); | |
| 393 | 393 | } | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -40,7 +40,7 @@ | |||
| 40 | 40 | import static org.patternfly.core.Aria.controls; | |
| 41 | 41 | import static org.patternfly.core.Aria.expanded; | |
| 42 | 42 | import static org.patternfly.core.Aria.labelledBy; | |
| 43 | - import static org.patternfly.icon.IconSets.rhUi.caretRight; | ||
| 43 | + import static org.patternfly.icon.IconSets.rhMicrons.caretDown; | ||
| 44 | 44 | import static org.patternfly.style.Classes.component; | |
| 45 | 45 | import static org.patternfly.style.Classes.content; | |
| 46 | 46 | import static org.patternfly.style.Classes.control; | |
@@ -150,7 +150,7 @@ public DataListItem expandable(ToggleHandler<DataListItem> toggleHandler) { | |||
| 150 | 150 | .aria(expanded, false) | |
| 151 | 151 | .on(click, e -> toggle()) | |
| 152 | 152 | .add(div().css(component(dataList, toggle, icon)) | |
| 153 | - .add(caretRight().element()))) | ||
| 153 | + .add(caretDown().element()))) | ||
| 154 | 154 | .element()); | |
| 155 | 155 | wireExpandable(); | |
| 156 | 156 | return this; | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -51,7 +51,7 @@ | |||
| 51 | 51 | import static org.patternfly.core.Aria.expanded; | |
| 52 | 52 | import static org.patternfly.core.Attributes.role; | |
| 53 | 53 | import static org.patternfly.core.Roles.presentation; | |
| 54 | - import static org.patternfly.icon.IconSets.rhUi.caretRight; | ||
| 54 | + import static org.patternfly.icon.IconSets.rhMicrons.caretDown; | ||
| 55 | 55 | import static org.patternfly.overlay.CssPositioning.anchorNameSupported; | |
| 56 | 56 | import static org.patternfly.overlay.Overlay.overlay; | |
| 57 | 57 | import static org.patternfly.style.Classes.component; | |
@@ -103,7 +103,7 @@ static OverflowTab overflowTab() { | |||
| 103 | 103 | .aria(hasPopup, "menu") | |
| 104 | 104 | .add(textElement = span().css(component(Classes.tabs, item, Classes.text)).element()) | |
| 105 | 105 | .add(span().css(component(Classes.tabs, link, toggle, icon)) | |
| 106 | - .add(caretRight()))); | ||
| 106 | + .add(caretDown()))); | ||
| 107 | 107 | ||
| 108 | 108 | HTMLElement overlayElement; | |
| 109 | 109 | add(overlayElement = div().css(component(Classes.overlay)) | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -30,7 +30,7 @@ | |||
| 30 | 30 | import static org.patternfly.component.button.Button.button; | |
| 31 | 31 | import static org.patternfly.core.Aria.expanded; | |
| 32 | 32 | import static org.patternfly.core.Aria.labelledBy; | |
| 33 | - import static org.patternfly.icon.IconSets.rhUi.caretRight; | ||
| 33 | + import static org.patternfly.icon.IconSets.rhMicrons.caretDown; | ||
| 34 | 34 | import static org.patternfly.style.Classes.component; | |
| 35 | 35 | import static org.patternfly.style.Classes.tabs; | |
| 36 | 36 | import static org.patternfly.style.Classes.toggle; | |
@@ -58,7 +58,7 @@ static TabsToggle tabsToggle() { | |||
| 58 | 58 | String toggleTextId = Id.unique(ComponentType.Tabs.id, "toggle", "text"); | |
| 59 | 59 | add(div().css(component(tabs, toggle, Classes.button)) | |
| 60 | 60 | .add(button = button().plain() | |
| 61 | - .iconAndText(caretRight(), "") | ||
| 61 | + .iconAndText(caretDown(), "") | ||
| 62 | 62 | .id(toggleButtonId) | |
| 63 | 63 | .aria(expanded, false) | |
| 64 | 64 | .aria(labelledBy, toggleButtonId + " " + toggleTextId) | |
0 commit comments