fix: use caretRight icon for tree view toggle instead of caretDown · patternfly-java/patternfly-java@d4241f0 · GitHub

patternfly-java / patternfly-java Public

• Notifications You must be signed in to change notification settings
• Fork 5
• Star 34

• Code
• Issues 39
• Pull requests
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d4241f0

Browse filesBrowse the repository at this point in the historyBrowse files

hpehl

committed

fix: use caretRight icon for tree view toggle instead of caretDown

The tree view toggle was using rhMicrons.caretDown (a downward-pointing caret), but PatternFly uses a right-pointing chevron (caretRight) that CSS-rotates 90° when expanded. This fixes the icon mismatch across all three TreeViewType variants (default, selectableItems, checkboxes).

1 parent 10f55de commit d4241f0
Copy full SHA for d4241f0

3 files changed

+859-713Lines changed: 859 additions & 713 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• CHANGELOG.md
• components/src/main/java/org/patternfly/component/tree
  • TreeViewItem.java
• showcase
  • pnpm-lock.yaml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎CHANGELOG.md‎

Copy file name to clipboardExpand all lines: CHANGELOG.md

+4Lines changed: 4 additions & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
6	6
7	7	## [Unreleased]
8	8
	9	+ ### Fixed
	10	+
	11	+ - Fix tree view toggle icon to use `rhMicrons.caretRight` instead of `rhMicrons.caretDown`, matching PatternFly's right-pointing chevron that rotates on expand
	12	+
9	13	## [0.9.6] - 2026-08-17
10	14
11	15	### Added

Collapse file

‎components/src/main/java/org/patternfly/component/tree/TreeViewItem.java‎

Copy file name to clipboardExpand all lines: components/src/main/java/org/patternfly/component/tree/TreeViewItem.java

+4-4Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -89,7 +89,7 @@
89	89	import static org.patternfly.core.Roles.group;
90	90	import static org.patternfly.core.Roles.treeItem;
91	91	import static org.patternfly.core.Timeouts.LOADING_TIMEOUT;
92		- import static org.patternfly.icon.IconSets.rhMicrons.caretDown;
	92	+ import static org.patternfly.icon.IconSets.rhMicrons.caretRight;
93	93	import static org.patternfly.icon.IconSets.rhUi.errorFill;
94	94	import static org.patternfly.style.Classes.check;
95	95	import static org.patternfly.style.Classes.component;
@@ -515,7 +515,7 @@ void finishDOM(TreeView tv) {
515	515	})
516	516	.element();
517	517	toggleElement = span().css(component(treeView, node, toggle))
518		- .add(span().css(component(treeView, node, toggle, Classes.icon)).add(caretDown()))
	518	+ .add(span().css(component(treeView, node, toggle, Classes.icon)).add(caretRight()))
519	519	.element();
520	520	textElement = span().css(component(treeView, node, Classes.text)).element();
521	521	tabElement = nodeElement;
@@ -535,7 +535,7 @@ void finishDOM(TreeView tv) {
535	535	tv.toggle(this);
536	536	e.stopPropagation();
537	537	})
538		- .add(span().css(component(treeView, node, toggle, Classes.icon)).add(caretDown()))
	538	+ .add(span().css(component(treeView, node, toggle, Classes.icon)).add(caretRight()))
539	539	.element();
540	540	textElement = button().css(component(treeView, node, Classes.text))
541	541	.attr(tabindex, -1)
@@ -559,7 +559,7 @@ void finishDOM(TreeView tv) {
559	559	tv.toggle(this);
560	560	e.stopPropagation();
561	561	})
562		- .add(span().css(component(treeView, node, toggle, Classes.icon)).add(caretDown()))
	562	+ .add(span().css(component(treeView, node, toggle, Classes.icon)).add(caretRight()))
563	563	.element();
564	564	textElement = span().css(component(treeView, node, Classes.text)).element();
565	565	containerElement.appendChild(span().css(component(treeView, node, check))

0 commit comments

Comments

0 (0)