FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes failing to recognize mock methods when using getMockForTrait() by BluePsyduck · Pull Request #29 · phpstan/phpstan-phpunit · GitHub

  1. phpstan
  2. phpstan-phpunit

Repository navigation

Fixes failing to recognize mock methods when using getMockForTrait() #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BluePsyduck wants to merge 2 commits into
base: 1.1.x
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 4 Commits 2 Checks 0 Files changed
Open

Fixes failing to recognize mock methods when using getMockForTrait() #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e23ca9
Fixes failing tests in current master.
BluePsyduck Sep 25, 2018
65e6eaa
Fixes failing to recognize mock methods when using getMockForTrait().
BluePsyduck Sep 25, 2018
File filter

Filter by extension

Filter by extension .php  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions src/Type/PHPUnit/MockBuilderDynamicReturnTypeExtension.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
[
'getMock',
'getMockForAbstractClass',
'getMockForTrait',
],
true
)) {
Expand Down
2 changes: 1 addition & 1 deletion tests/Rules/PHPUnit/AssertSameMethodDifferentTypesRuleTest.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class AssertSameMethodDifferentTypesRuleTest extends \PHPStan\Testing\RuleTestCa

protected function getRule(): Rule
{
return new ImpossibleCheckTypeMethodCallRule(new ImpossibleCheckTypeHelper($this->getTypeSpecifier()), true);
return new ImpossibleCheckTypeMethodCallRule(new ImpossibleCheckTypeHelper($this->createBroker(), $this->getTypeSpecifier()), true);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/Rules/PHPUnit/AssertSameStaticMethodDifferentTypesRuleTest.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class AssertSameStaticMethodDifferentTypesRuleTest extends \PHPStan\Testing\Rule

protected function getRule(): Rule
{
return new ImpossibleCheckTypeStaticMethodCallRule(new ImpossibleCheckTypeHelper($this->getTypeSpecifier()), true);
return new ImpossibleCheckTypeStaticMethodCallRule(new ImpossibleCheckTypeHelper($this->createBroker(), $this->getTypeSpecifier()), true);
}

/**
Expand Down
Back | FazBrowse Home | New Git URL