FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Comparing master...3.3 · polybar/polybar · GitHub

/ polybar Public
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: polybar/polybar
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
Could not load branches
Nothing to show
{{ refName }}
...
head repository: polybar/polybar
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.3
Choose a head ref
Could not load branches
Nothing to show
{{ refName }}
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 27 files changed
  • 7 contributors

Commits on Mar 25, 2019

  1. fix(xworkspaces): FPE when no _NET_DESKTOP_NAMES (#1576) 

    Fixes #1462
    kronn authored and patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    9702eed View commit details
    Browse the repository at this point in the history

  2. fix(tray): correctly handle transparency when using offset (#1571) 

    This patch adds support for observing multiple slices of the desktop background.
This is used for the tray so that it doesn't have to rely on the bar's rect to
get the desktop background. In particular, it now handles the case where the
tray is not contained fully within the bar's outer rect (for example, when using tray-offset-{x,y})

Co-Authored-By: bennofs <benno.fuenfstueck@gmail.com>
    bennofs authored and patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    78ae208 View commit details
    Browse the repository at this point in the history

  3. aur: Use tar file for polybar package 

    We provide the polybar.tar as part of our release process so it is more
efficient to let users build directly from the uploaded archive
    patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    ecfbd0a View commit details
    Browse the repository at this point in the history

  4. build: Add build instructions for tar file

    patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    e5eafe1 View commit details
    Browse the repository at this point in the history

  5. aur: fix tar url

    patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    ff8c2d7 View commit details
    Browse the repository at this point in the history

  6. fix(i3): crash without <label-state> (#1591) 

    Fixes #975
    Ddone authored and patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    8f77255 View commit details
    Browse the repository at this point in the history

  7. fix(fs): Calculate free bytes properly 

    Seems this was missed in a682d2a

This is now also consistent with what df does

Closes #743
    patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    d112718 View commit details
    Browse the repository at this point in the history

  8. fix(renderer): Handling of missing root pixmap (#1608) 

    Polybar had issues when there is no background set or set by a tool like imagemagick which doesn't add the root pixmap to the root window properties.

There's not much we can do about it, but at least polybar doesn't crash anymore.

Fixes #1582 
Fixes #1585 

* fix(tray_manager): only enable transparency if neccessary

Previously, we always enabled transparency

* fix(background_manager): avoid needless fetching

* fix(renderer): move logging message to correct place

* fix(background_manager): handle dummy pixmap (_XSETROOT_ID) right

* fix(background_manager): more initialization + don't free on error

Freeing on error is incorrect, since we could still be called again later in
which case we still need the resources.

* fix(background_manager): add more infos to trace logs

* fix(background): correct typo (XROOTMAP -> XROOTPMAP)

* fix(background_manager): do not report "no background" as error

* style(background_manager): use braces for if

Co-Authored-By: bennofs <benno.fuenfstueck@gmail.com>

* fix(background_manager): better error message for dummy pixmap

Co-Authored-By: bennofs <benno.fuenfstueck@gmail.com>

* style(background): some more style fixes

* fix(connection): initialize pixmap in all cases in root_pixmap()

* style(connection): improve readability using early return
    bennofs authored and patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    e582776 View commit details
    Browse the repository at this point in the history

  9. fix(net): buffer overflow when gathering ipv6 addr

    patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    4c9d4fb View commit details
    Browse the repository at this point in the history

  10. fix(xworkspace): Fully support _NET_DESKTOP_NAMES spec (#1579) 

    Ref https://specifications.freedesktop.org/wm-spec/wm-spec-latest.html#idm140200472706208

Fixes #1491
Fixes #248
Closes #904
    soubiliz authored and patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    ca0da3d View commit details
    Browse the repository at this point in the history

  11. git(xpp): Update submodule ref (#1647) 

    This fixes the link failure when configured with -DBUILD_SHARED_LIBS=ON
as reported in #1628. xpp will now always build a static lib

Ref polybar/xpp#15
    patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    2e2c02b View commit details
    Browse the repository at this point in the history

  12. fix(tray_client): remove copy ctor & assignment operator (#1675) 

    tray_client class contains a reference so copy assignment operator is implicitly deleted.
the dtor unembed the window so copying the class could lead to bug so the copy ctor is also deleted.

Fixes #1674
    Lomadriel authored and patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    44799c9 View commit details
    Browse the repository at this point in the history

  13. fix(controller): ignore SIGUSR1 until polybar is fully reloaded. (#1678) 

    To avoid polybar from being killed by SIGUSR1 during reloading, SIGUSR1 is ignored until the signal is registered in the new polybar process.

As stated in signal(7) man page, the ignored signals are still ignored after a call to a function of the execvX family.

    During an execve(2), the dispositions of handled signals are reset to the default;
    the dispositions of ignored signals are left unchanged.

Fixes #428
    Lomadriel authored and patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    4857192 View commit details
    Browse the repository at this point in the history

  14. fs: Fix incorrect size report on 32bit machines (#1699) 

    Cast before multiplication to avoid overflow.

Fixes #743
    notok authored and patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    3f98c80 View commit details
    Browse the repository at this point in the history

  15. fix(tray): fix offset for negative percentage (#1669) 

    tray-offset-{x,y} were clamped between [0, max_value] rather than [-max_value, max_value]. Therefore negative percentage were ignored.

Fixes #1666
    Lomadriel authored and patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    5789a25 View commit details
    Browse the repository at this point in the history

  16. fix(gtest): INSTANTIATE_TEST_CASE_P with zero variadic arguments 

    Due to google/googletest#1419 [1], we had to add a comma after the last
argument of INSTANTIATE_TEST_CASE_P.

This was "fixed" in a backwards incompatible way in the googletest
project in 7c4164bf404d899b6d4c74beb1070da5647f55a2

[1]: google/googletest#1419
    patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    d2ac21a View commit details
    Browse the repository at this point in the history

  17. refactor(gtest): TestCase->TestSuite 

    googletest deprecated the TEST_CASE terminology in
3a460a26b7a91abf87af7f31b93d29f930e25c82
    patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    587efdd View commit details
    Browse the repository at this point in the history

  18. Release 3.3.1 

    Changelog

Fixes:
* `internal/xworkspaces`:
    * Crash when WM doesn't set `_NET_DESKTOP_NAMES` (#1576), see #1462
    * Workspace removal not always detected (#1579), see #1491, #248
* `internal/i3`: Crash when `<label-state>` was not added to `format` (#1591), see #975
* `internal/fs`: Incorrect sizes on some machines (#1612, #1699), see #743
* `internal/network`: Buffer overflow with ipv6 addresses (#1514)
* renderer: Show proper error when imagemagick is used to set the background (#1608), see #1582, #1585
* tray:
    * Wrong background for transparent trays when using `tray-offset-*` (#1571)
    * Build failure on clang8 (#1675), #1674
    * Allow negative offset values for `tray-offset-*` (#1669), see #1666
* build: Link failure when configuring with `-DBUILD_SHARED_LIBS=ON` (#1647, polybar/xpp#15), see #1628
* controller: Crash when reloading via `SIGUSR1` too fast (#1678), #428
    patrick96 committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    a6bfcf8 View commit details
    Browse the repository at this point in the history
Loading
Back | FazBrowse Home | New Git URL