fix(schema): allow to pass an `{Object}` (`options.syntax/options.str… · webpack/postcss-loader@58e9996 · GitHub

webpack / postcss-loader Public

• Notifications You must be signed in to change notification settings
• Fork 211
• Star 2.8k

• Code
• Issues 2
• Pull requests 12
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 58e9996

Browse filesBrowse the repository at this point in the historyBrowse files

michael-ciniawsky

authored

fix(schema): allow to pass an {Object} (options.syntax/options.stringifier) (#300)

1 parent 30d8d51 commit 58e9996
Copy full SHA for 58e9996

8 files changed

+12-9Lines changed: 12 additions & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • options.json
• test
  • loader.test.js
  • options
    • __snapshots__
      • parser.test.js.snap
      • stringifier.test.js.snap
      • syntax.test.js.snap
    • parser.test.js
    • stringifier.test.js
    • syntax.test.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/options.json‎

Copy file name to clipboardExpand all lines: lib/options.json

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -20,10 +20,10 @@
20	20	"type": [ "string", "object" ]
21	21	},
22	22	"syntax": {
23		- "type": "string"
	23	+ "type": [ "string", "object" ]
24	24	},
25	25	"stringifier": {
26		- "type": "string"
	26	+ "type": [ "string", "object" ]
27	27	},
28	28	"sourceMap": {
29	29	"type": [ "string", "boolean" ]

Collapse file

‎test/loader.test.js‎

Copy file name to clipboardExpand all lines: test/loader.test.js

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -5,7 +5,6 @@ const { loader } = require('./helpers/compilation')
5	5
6	6	describe('Loader', () => {
7	7	test('Default', () => {
8		- const _ = /style\.(exec\.js|js)$/
9	8	const config = {
10	9	loader: {
11	10	options: {

Collapse file

‎test/options/__snapshots__/parser.test.js.snap‎

Copy file name to clipboard

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,5 +1,5 @@
1	1	// Jest Snapshot v1, https://goo.gl/fbAQLP
2	2
3		- exports[`Options Parser - {Function} 1`] = `"module.exports = \\"a {\\\\n color: black\\\\n}\\\\n\\""`;
	3	+ exports[`Options Parser - {Object} 1`] = `"module.exports = \\"a {\\\\n color: black\\\\n}\\\\n\\""`;
4	4
5	5	exports[`Options Parser - {String} 1`] = `"module.exports = \\"a {\\\\n color: black\\\\n}\\\\n\\""`;

Collapse file

‎test/options/__snapshots__/stringifier.test.js.snap‎

Copy file name to clipboard

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,3 +1,5 @@
1	1	// Jest Snapshot v1, https://goo.gl/fbAQLP
2	2
	3	+ exports[`Options Stringifier - {Object} 1`] = `"module.exports = \\"a color: black\\\\n\\""`;
	4	+
3	5	exports[`Options Stringifier - {String} 1`] = `"module.exports = \\"a color: black\\\\n\\""`;

Collapse file

‎test/options/__snapshots__/syntax.test.js.snap‎

Copy file name to clipboard

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,3 +1,5 @@
1	1	// Jest Snapshot v1, https://goo.gl/fbAQLP
2	2
	3	+ exports[`Options Syntax - {Object} 1`] = `"module.exports = \\"a\\\\n color: black\\\\n\\""`;
	4	+
3	5	exports[`Options Syntax - {String} 1`] = `"module.exports = \\"a\\\\n color: black\\\\n\\""`;

Collapse file

‎test/options/parser.test.js‎

Copy file name to clipboardExpand all lines: test/options/parser.test.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -21,7 +21,7 @@ describe('Options', () => {
21	21	})
22	22	})
23	23
24		- test('Parser - {Function}', () => {
	24	+ test('Parser - {Object}', () => {
25	25	const config = {
26	26	loader: {
27	27	options: {

Collapse file

‎test/options/stringifier.test.js‎

Copy file name to clipboardExpand all lines: test/options/stringifier.test.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -20,8 +20,8 @@ describe('Options', () => {
20	20	expect(src).toMatchSnapshot()
21	21	})
22	22	})
23		- // TODO fix schema
24		- test.skip('Stringifier - {Function}', () => {
	23	+
	24	+ test('Stringifier - {Object}', () => {
25	25	const config = {
26	26	loader: {
27	27	options: {

Collapse file

‎test/options/syntax.test.js‎

Copy file name to clipboardExpand all lines: test/options/syntax.test.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -20,8 +20,8 @@ describe('Options', () => {
20	20	expect(src).toMatchSnapshot()
21	21	})
22	22	})
23		- // TODO fix schema
24		- test.skip('Syntax - {Function}', () => {
	23	+
	24	+ test('Syntax - {Object}', () => {
25	25	const config = {
26	26	loader: {
27	27	options: {

0 commit comments

Comments

0 (0)