FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Podman support by using docker api instead of the executable · Issue #2779 · pre-commit/pre-commit · GitHub

Repository navigation

Podman support by using docker api instead of the executable #2779

Closed

Description

search you tried in the issue tracker

podman

describe your actual problem

To support docker_image / docker hooks with podman as backend and without any wrapper scripts, Docker python library (which uses the api) could be used instead of running the executables with subprocess.

This would simplify the workflow with podman, since currently these hooks require either actual docker binaries present (which are connecting to the podman api) or wrapping the podman executable with a docker alias/shell wrapper/etc.

This could also help with the error messages, since errors thrown from the api when launching the container are separate from the return code of the container.

pre-commit --version

pre-commit 3.1.0

Activity

  1. asottile commented on Feb 24, 2023

    Member

    can't take on that dependency -- it's been a constant thorn in my side in the past

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL