FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Single-element tuples are printed incorrectly · Issue #12 · prettier/plugin-python · GitHub

This repository was archived by the owner on Oct 1, 2019. It is now read-only.
  1. prettier
  2. plugin-python

Repository navigation

This repository was archived by the owner on Oct 1, 2019. It is now read-only.

Single-element tuples are printed incorrectly #12

Closed
Closed
Single-element tuples are printed incorrectly#12

Description

taion
opened on Dec 26, 2017

In:

a = 1,

Out:

a = 1

The trailing comma is necessary for single-element tuples in Python, with out without the parens (i.e. (1,), not (1)).

Activity

  1. taion commented on Dec 26, 2017

    taion
    on Dec 26, 2017
    ContributorAuthor

    Tuple printing is somewhat questionable in general.

    In:

    a = (
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
)

    Out:

    a = "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf"

  2. taion commented on Dec 26, 2017

    taion
    on Dec 26, 2017
    ContributorAuthor

    Lists too, actually:

    # In:
a = [
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
    "asdfasdfasdfasdfasdfasdf",
]

# Out:
a = ["asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf", "asdfasdfasdfasdfasdfasdf"]

    These are all with defaults, i.e. max width of 80 (other than enabling the Python plugin).

  3. azz commented on Dec 26, 2017

    azz
    on Dec 26, 2017
    Member

    Might be missing a group()?

  4. taion commented on Dec 26, 2017

    taion
    on Dec 26, 2017
    ContributorAuthor

    For the wrapping things, yeah.

    The single-element tuple thing in the OP is actually a syntax issue, though. The printed code is not equivalent to the input code.

  5. taion commented on Dec 31, 2017

    taion
    on Dec 31, 2017
    ContributorAuthor

    Empty tuples are broken as well:

    # In:
a = ()

# Out:
a =
  6. azz
    closed this as completedin #17on Jan 4, 2018

  7. taion commented on Jan 4, 2018

    taion
    on Jan 4, 2018
    ContributorAuthor

    This isn't fully resolved. Empty tuples I believe now will get printed like a = ,, which is still invalid syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      Back | FazBrowse Home | New Git URL