Add ability to filter metrics in DropwizardExports - #574
Merged
brian-brazil merged 6 commits intoOct 14, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fix prometheus#573 Signed-off-by: Vasily Vasilkov <vgv@ecwid.com>
Add comments Fix prometheus#573 Signed-off-by: Vasily Vasilkov <vgv@ecwid.com>
Copy link
Copy Markdown
Contributor
Author
|
@brian-brazil Hi, could you please review this patch? |
Sorry, something went wrong.
Code review fixes Fix prometheus#573 Signed-off-by: Vasily Vasilkov <vgv@ecwid.com>
Code review fixes, split wildcard import into concrete classes Fix prometheus#573 Signed-off-by: Vasily Vasilkov <vgv@ecwid.com>
brian-brazil
reviewed
Oct 9, 2020
Comment thread
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Outdated
Comment thread
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Outdated
Comment thread
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Outdated
Comment thread
simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java
Code review fixes Fix prometheus#573 Signed-off-by: Vasily Vasilkov <vgv@ecwid.com>
Code review fixes Fix prometheus#573 Signed-off-by: Vasily Vasilkov <vgv@ecwid.com>
Copy link
Copy Markdown
Contributor
|
Thanks! |
Sorry, something went wrong.
This was referenced Mar 11, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #573