Make sure GZIPOutputStream is always closed - #598
Merged
brian-brazil merged 1 commit intoOct 15, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Outdated
Comment thread
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This new indirection just makes the code harder to read for me.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This is still here.
Sorry, something went wrong.
brian-brazil
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can you also add the DCO?
Sorry, something went wrong.
Comment thread
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This is still here.
Sorry, something went wrong.
Signed-off-by: Andrey Turbanov <turbanoff@gmail.com>
turbanoff
force-pushed
the
close_gzipoutputstream_always
branch
from
87ba15c to
421bfe3
Compare
October 15, 2020 15:46
Copy link
Copy Markdown
Contributor
|
Thanks! |
Sorry, something went wrong.
This was referenced Mar 11, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leave GZIPOutputStream open is dangerous as it leads to native memory leak.
Use try-finally to make sure stream is always closed