Commit 66653b0
committed
test: fix captured-disposed analyzer hint and ambiguous OpenImageStream cref
- XisoExplorerKeepOpenTests: block-scope the keep-open explorer so the
Parallel.For lambda capture no longer trips 'captured variable is disposed
in the outer scope'.
- XisoStreamApiTests: qualify the OpenImageStream doc reference to the string
overload (the new FileShare overload made the bare cref ambiguous).1 parent 1346f72 commit 66653b0
2 files changed
Lines changed: 20 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -82,26 +82,27 @@ public void KeepOpen_OperationsMatchStatelessExplorer() | |||
| 82 | 82 | public void KeepOpen_ParallelMetadataOperations_Smoke() | |
| 83 | 83 | { | |
| 84 | 84 | string iso = CreateIso(); | |
| 85 | - using XisoExplorer explorer = new(iso, new XisoExplorerOptions { KeepOpen = true }); | ||
| 86 | - | ||
| 87 | - Parallel.For(0, 64, i => | ||
| 85 | + using (XisoExplorer explorer = new(iso, new XisoExplorerOptions { KeepOpen = true })) | ||
| 88 | 86 | { | |
| 89 | - switch (i % 4) | ||
| 87 | + Parallel.For(0, 64, i => | ||
| 90 | 88 | { | |
| 91 | - case 0: | ||
| 92 | - Assert.Equal(4, explorer.ListChildren("/").Count); | ||
| 93 | - break; | ||
| 94 | - case 1: | ||
| 95 | - Assert.Equal("a.txt", explorer.GetNode("/a.txt")!.Name); | ||
| 96 | - break; | ||
| 97 | - case 2: | ||
| 98 | - Assert.NotNull(explorer.ComputeHashHex("/b.txt", HashAlgorithmName.SHA256)); | ||
| 99 | - break; | ||
| 100 | - default: | ||
| 101 | - Assert.Equal("c.txt", explorer.ListChildren("/sub").Single().Name); | ||
| 102 | - break; | ||
| 103 | - } | ||
| 104 | - }); | ||
| 89 | + switch (i % 4) | ||
| 90 | + { | ||
| 91 | + case 0: | ||
| 92 | + Assert.Equal(4, explorer.ListChildren("/").Count); | ||
| 93 | + break; | ||
| 94 | + case 1: | ||
| 95 | + Assert.Equal("a.txt", explorer.GetNode("/a.txt")!.Name); | ||
| 96 | + break; | ||
| 97 | + case 2: | ||
| 98 | + Assert.NotNull(explorer.ComputeHashHex("/b.txt", HashAlgorithmName.SHA256)); | ||
| 99 | + break; | ||
| 100 | + default: | ||
| 101 | + Assert.Equal("c.txt", explorer.ListChildren("/sub").Single().Name); | ||
| 102 | + break; | ||
| 103 | + } | ||
| 104 | + }); | ||
| 105 | + } | ||
| 105 | 106 | } | |
| 106 | 107 | ||
| 107 | 108 | [Fact] | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,7 +5,7 @@ namespace XISOSharp.Tests; | |||
| 5 | 5 | ||
| 6 | 6 | /// <summary> | |
| 7 | 7 | /// Tests for the public stream-based read API (TODO #12, third bullet): | |
| 8 | - /// <see cref="XisoReader.OpenImageStream"/>, the <c>Stream</c> overloads of | ||
| 8 | + /// <see cref="XisoReader.OpenImageStream(string)"/>, the <c>Stream</c> overloads of | ||
| 9 | 9 | /// <c>Extract</c>/<c>UnpackImage</c>/<c>List</c>/<c>Tree</c>/<c>DecodeXiso</c>, | |
| 10 | 10 | /// and <see cref="XisoReader.IsOptimizedImage(Stream, int?)"/>. | |
| 11 | 11 | /// </summary> | |
0 commit comments