FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Check-news status: check that the news file is not empty. · Issue #127 · python/bedevere · GitHub

Repository navigation

Check-news status: check that the news file is not empty. #127

Closed

Description

In python/cpython#8857, they created an empty news file (to make the status pass?) 🤷‍♀️
I think it is possible to check for the content of the file, and ensure it is not empty, before posting the success status.

Activity

  1. terryjreedy commented on Aug 23, 2018

    Member

    After Cheryl Sabella had some experience, I asked her to include news files with her patches even though I would edit before pushing. Blank was fine. The reason for me was that it is much easier, when near ready to commit, to edit an existing file with the web editor than to push a new file.

    However, I see the danger that a commit could be made without the edit. If a check is added, a minimum of, say, 30 characters, might be reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL