| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -131,11 +131,19 @@ Wave_read Objects | |||
| 131 | 131 | ||
| 132 | 132 | Returns ``None``. | |
| 133 | 133 | ||
| 134 | + .. deprecated-removed:: 3.13 3.15 | ||
| 135 | + The method only existed for compatibility with the :mod:`!aifc` module | ||
| 136 | + which has been removed in Python 3.13. | ||
| 137 | + | ||
| 134 | 138 | ||
| 135 | 139 | .. method:: getmark(id) | |
| 136 | 140 | ||
| 137 | 141 | Raise an error. | |
| 138 | 142 | ||
| 143 | + .. deprecated-removed:: 3.13 3.15 | ||
| 144 | + The method only existed for compatibility with the :mod:`!aifc` module | ||
| 145 | + which has been removed in Python 3.13. | ||
| 146 | + | ||
| 139 | 147 | The following two methods define a term "position" which is compatible between | |
| 140 | 148 | them, and is otherwise implementation dependent. | |
| 141 | 149 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -115,6 +115,10 @@ Optimizations | |||
| 115 | 115 | Deprecated | |
| 116 | 116 | ========== | |
| 117 | 117 | ||
| 118 | + * :mod:`wave`: Deprecate the ``getmark()``, ``setmark()`` and ``getmarkers()`` | ||
| 119 | + methods of the :class:`wave.Wave_read` and :class:`wave.Wave_write` classes. | ||
| 120 | + They will be removed in Python 3.15. | ||
| 121 | + (Contributed by Victor Stinner in :gh:`105096`.) | ||
| 118 | 122 | ||
| 119 | 123 | ||
| 120 | 124 | Removed | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -136,6 +136,32 @@ def test__all__(self): | |||
| 136 | 136 | not_exported = {'WAVE_FORMAT_PCM', 'WAVE_FORMAT_EXTENSIBLE', 'KSDATAFORMAT_SUBTYPE_PCM'} | |
| 137 | 137 | support.check__all__(self, wave, not_exported=not_exported) | |
| 138 | 138 | ||
| 139 | + def test_read_deprecations(self): | ||
| 140 | + filename = support.findfile('pluck-pcm8.wav', subdir='audiodata') | ||
| 141 | + with wave.open(filename) as reader: | ||
| 142 | + with self.assertWarns(DeprecationWarning): | ||
| 143 | + with self.assertRaises(wave.Error): | ||
| 144 | + reader.getmark('mark') | ||
| 145 | + with self.assertWarns(DeprecationWarning): | ||
| 146 | + self.assertIsNone(reader.getmarkers()) | ||
| 147 | + | ||
| 148 | + def test_write_deprecations(self): | ||
| 149 | + with io.BytesIO(b'') as tmpfile: | ||
| 150 | + with wave.open(tmpfile, 'wb') as writer: | ||
| 151 | + writer.setnchannels(1) | ||
| 152 | + writer.setsampwidth(1) | ||
| 153 | + writer.setframerate(1) | ||
| 154 | + writer.setcomptype('NONE', 'not compressed') | ||
| 155 | + | ||
| 156 | + with self.assertWarns(DeprecationWarning): | ||
| 157 | + with self.assertRaises(wave.Error): | ||
| 158 | + writer.setmark(0, 0, 'mark') | ||
| 159 | + with self.assertWarns(DeprecationWarning): | ||
| 160 | + with self.assertRaises(wave.Error): | ||
| 161 | + writer.getmark('mark') | ||
| 162 | + with self.assertWarns(DeprecationWarning): | ||
| 163 | + self.assertIsNone(writer.getmarkers()) | ||
| 164 | + | ||
| 139 | 165 | ||
| 140 | 166 | class WaveLowLevelTest(unittest.TestCase): | |
| 141 | 167 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -342,9 +342,13 @@ def getparams(self): | |||
| 342 | 342 | self.getcomptype(), self.getcompname()) | |
| 343 | 343 | ||
| 344 | 344 | def getmarkers(self): | |
| 345 | + import warnings | ||
| 346 | + warnings._deprecated("Wave_read.getmarkers", remove=(3, 15)) | ||
| 345 | 347 | return None | |
| 346 | 348 | ||
| 347 | 349 | def getmark(self, id): | |
| 350 | + import warnings | ||
| 351 | + warnings._deprecated("Wave_read.getmark", remove=(3, 15)) | ||
| 348 | 352 | raise Error('no marks') | |
| 349 | 353 | ||
| 350 | 354 | def setpos(self, pos): | |
@@ -548,12 +552,18 @@ def getparams(self): | |||
| 548 | 552 | self._nframes, self._comptype, self._compname) | |
| 549 | 553 | ||
| 550 | 554 | def setmark(self, id, pos, name): | |
| 555 | + import warnings | ||
| 556 | + warnings._deprecated("Wave_write.setmark", remove=(3, 15)) | ||
| 551 | 557 | raise Error('setmark() not supported') | |
| 552 | 558 | ||
| 553 | 559 | def getmark(self, id): | |
| 560 | + import warnings | ||
| 561 | + warnings._deprecated("Wave_write.getmark", remove=(3, 15)) | ||
| 554 | 562 | raise Error('no marks') | |
| 555 | 563 | ||
| 556 | 564 | def getmarkers(self): | |
| 565 | + import warnings | ||
| 566 | + warnings._deprecated("Wave_write.getmarkers", remove=(3, 15)) | ||
| 557 | 567 | return None | |
| 558 | 568 | ||
| 559 | 569 | def tell(self): | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,3 @@ | |||
| 1 | + :mod:`wave`: Deprecate the ``getmark()``, ``setmark()`` and ``getmarkers()`` | ||
| 2 | + methods of the :class:`wave.Wave_read` and :class:`wave.Wave_write` classes. | ||
| 3 | + They will be removed in Python 3.15. Patch by Victor Stinner. | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments