Add a warning message about PyOS_snprintf (GH-95993) · python/cpython@0a84b7a · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 36.1k
• Star 77.2k

• Code
• Issues 5k+
• Pull requests 2.7k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0a84b7a

Browse filesBrowse the repository at this point in the historyBrowse files

miss-islington

and

eric-wieser

authored

Add a warning message about PyOS_snprintf (GH-95993)

(cherry picked from commit c7b2204) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>

1 parent 107ba92 commit 0a84b7a
Copy full SHA for 0a84b7a

2 files changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Doc/c-api
  • conversion.rst
• Python
  • mysnprintf.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Doc/c-api/conversion.rst‎

Copy file name to clipboardExpand all lines: Doc/c-api/conversion.rst

+2-1Lines changed: 2 additions & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -28,7 +28,8 @@ not.
28	28	The wrappers ensure that ``str[size-1]`` is always ``'\0'`` upon return. They
29	29	never write more than *size* bytes (including the trailing ``'\0'``) into str.
30	30	Both functions require that ``str != NULL``, ``size > 0``, ``format != NULL``
31		- and ``size < INT_MAX``.
	31	+ and ``size < INT_MAX``. Note that this means there is no equivalent to the C99
	32	+ ``n = snprintf(NULL, 0, ...)`` which would determine the necessary buffer size.
32	33
33	34	The return value (*rv*) for these functions should be interpreted as follows:
34	35

Collapse file

‎Python/mysnprintf.c‎

Copy file name to clipboardExpand all lines: Python/mysnprintf.c

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -9,6 +9,7 @@
9	9	would have been written had the buffer not been too small, and to set
10	10	the last byte of the buffer to \0. At least MS _vsnprintf returns a
11	11	negative value instead, and fills the entire buffer with non-\0 data.
	12	+ Unlike C99, our wrappers do not support passing a null buffer.
12	13
13	14	The wrappers ensure that str[size-1] is always \0 upon return.
14	15

0 commit comments

Comments

0 (0)