Try to fix test_time.test_AsSecondsDouble() on "x86 Gentoo Non-Debug … · python/cpython@1efbeba · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 36.2k
• Star 77.2k

• Code
• Issues 5k+
• Pull requests 2.7k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1efbeba

Browse filesBrowse the repository at this point in the historyBrowse files

vstinner

committed

Try to fix test_time.test_AsSecondsDouble() on "x86 Gentoo Non-Debug with X 3.x" buildbot

Use volatile keyword in _PyTime_Round()

1 parent 350b518 commit 1efbeba
Copy full SHA for 1efbeba

1 file changed

+8-3Lines changed: 8 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Python
  • pytime.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Python/pytime.c‎

Copy file name to clipboardExpand all lines: Python/pytime.c

+8-3Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -75,12 +75,17 @@ _PyTime_RoundHalfEven(double x)
75	75	static double
76	76	_PyTime_Round(double x, _PyTime_round_t round)
77	77	{
	78	+ /* volatile avoids optimization changing how numbers are rounded */
	79	+ volatile double d;
	80	+
	81	+ d = x;
78	82	if (round == _PyTime_ROUND_HALF_EVEN)
79		- return _PyTime_RoundHalfEven(x);
	83	+ d = _PyTime_RoundHalfEven(d);
80	84	else if (round == _PyTime_ROUND_CEILING)
81		- return ceil(x);
	85	+ d = ceil(d);
82	86	else
83		- return floor(x);
	87	+ d = floor(d);
	88	+ return d;
84	89	}
85	90
86	91	static int

0 commit comments

Comments

0 (0)