Repository navigation
Commit 3944e9b
The `make_gen()` function creates and tracks generator/coro objects, but
doesn't fully initialize all the fields. At a minimum, we need to
initialize all the fields that may be accessed by gen_traverse because
the call to `compute_cr_origin()` can trigger a GC.
(cherry picked from commit 574405c)
Co-authored-by: Sam Gross <colesbury@gmail.com>
1 parent 564bb00 commit 3944e9b
2 files changed
Lines changed: 4 additions & 0 deletions
File tree
- Misc/NEWS.d/next/Core_and_Builtins
- Objects
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,3 @@ | |||
| 1 | + Fix a crash in Python's :term:`garbage collector <garbage collection>` due to | ||
| 2 | + partially initialized :term:`coroutine` objects when coroutine origin tracking | ||
| 3 | + depth is enabled (:func:`sys.set_coroutine_origin_tracking_depth`). | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -922,6 +922,7 @@ make_gen(PyTypeObject *type, PyFunctionObject *func) | |||
| 922 | 922 | gen->gi_weakreflist = NULL; | |
| 923 | 923 | gen->gi_exc_state.exc_value = NULL; | |
| 924 | 924 | gen->gi_exc_state.previous_item = NULL; | |
| 925 | + gen->gi_iframe.f_executable = PyStackRef_None; | ||
| 925 | 926 | assert(func->func_name != NULL); | |
| 926 | 927 | gen->gi_name = Py_NewRef(func->func_name); | |
| 927 | 928 | assert(func->func_qualname != NULL); | |
0 commit comments