| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -167,6 +167,18 @@ def test_ExitAsDefault(self): | |||
| 167 | 167 | 'expected failures=1, unexpected successes=1)\n') | |
| 168 | 168 | self.assertTrue(out.endswith(expected)) | |
| 169 | 169 | ||
| 170 | + def test_ExitSkippedSuite(self): | ||
| 171 | + stream = BufferedWriter() | ||
| 172 | + with self.assertRaises(SystemExit) as cm: | ||
| 173 | + unittest.main( | ||
| 174 | + argv=["foobar", "-k", "testSkipped"], | ||
| 175 | + testRunner=unittest.TextTestRunner(stream=stream), | ||
| 176 | + testLoader=self.TestLoader(self.FooBar)) | ||
| 177 | + self.assertEqual(cm.exception.code, 0) | ||
| 178 | + out = stream.getvalue() | ||
| 179 | + expected = '\n\nOK (skipped=1)\n' | ||
| 180 | + self.assertTrue(out.endswith(expected)) | ||
| 181 | + | ||
| 170 | 182 | def test_ExitEmptySuite(self): | |
| 171 | 183 | stream = BufferedWriter() | |
| 172 | 184 | with self.assertRaises(SystemExit) as cm: | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -269,7 +269,7 @@ def runTests(self): | |||
| 269 | 269 | testRunner = self.testRunner | |
| 270 | 270 | self.result = testRunner.run(self.test) | |
| 271 | 271 | if self.exit: | |
| 272 | - if self.result.testsRun == 0: | ||
| 272 | + if self.result.testsRun == 0 and len(self.result.skipped) == 0: | ||
| 273 | 273 | sys.exit(_NO_TESTS_EXITCODE) | |
| 274 | 274 | elif self.result.wasSuccessful(): | |
| 275 | 275 | sys.exit(0) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -274,7 +274,7 @@ def run(self, test): | |||
| 274 | 274 | infos.append("failures=%d" % failed) | |
| 275 | 275 | if errored: | |
| 276 | 276 | infos.append("errors=%d" % errored) | |
| 277 | - elif run == 0: | ||
| 277 | + elif run == 0 and not skipped: | ||
| 278 | 278 | self.stream.write("NO TESTS RAN") | |
| 279 | 279 | else: | |
| 280 | 280 | self.stream.write("OK") | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,3 @@ | |||
| 1 | + unittest runner: Don't exit 5 if tests were skipped. The intention of | ||
| 2 | + exiting 5 was to detect issues where the test suite wasn't discovered at | ||
| 3 | + all. If we skipped tests, it was correctly discovered. | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments