gh-145187: Fix crash on invalid type parameter bound expression in co… · python/cpython@5e61a16 · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 36.1k
• Star 77.2k

• Code
• Issues 5k+
• Pull requests 2.7k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5e61a16

Browse filesBrowse the repository at this point in the historyBrowse files

StanFromIreland

authored

gh-145187: Fix crash on invalid type parameter bound expression in conditional block (GH-145188)

Fix parsing crash found by oss-fuzz

1 parent 56c4f10 commit 5e61a16
Copy full SHA for 5e61a16

3 files changed

+12-3Lines changed: 12 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Lib/test
  • test_type_params.py
• Misc/NEWS.d/next/Core_and_Builtins
  • 2026-02-24-18-30-56.gh-issue-145187.YjPu1Z.rst
• Python
  • codegen.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Lib/test/test_type_params.py‎

Copy file name to clipboardExpand all lines: Lib/test/test_type_params.py

+7Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -152,6 +152,13 @@ def test_incorrect_mro_explicit_object(self):
152	152	with self.assertRaisesRegex(TypeError, r"\(MRO\) for bases object, Generic"):
153	153	class My[X](object): ...
154	154
	155	+ def test_compile_error_in_type_param_bound(self):
	156	+ # This should not crash, see gh-145187
	157	+ check_syntax_error(
	158	+ self,
	159	+ "if True:\n class h[l:{7for*()in 0}]:2"
	160	+ )
	161	+
155	162
156	163	class TypeParamsNonlocalTest(unittest.TestCase):
157	164	def test_nonlocal_disallowed_01(self):

Collapse file

‎Misc/NEWS.d/next/Core_and_Builtins/2026-02-24-18-30-56.gh-issue-145187.YjPu1Z.rst‎

Copy file name to clipboard

+2Lines changed: 2 additions & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,2 @@
	1	+ Fix compiler assertion fail when a type parameter bound contains an invalid
	2	+ expression in a conditional block.

Collapse file

‎Python/codegen.c‎

Copy file name to clipboardExpand all lines: Python/codegen.c

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -1244,11 +1244,11 @@ codegen_type_param_bound_or_default(compiler *c, expr_ty e,
1244	1244	ADDOP_LOAD_CONST_NEW(c, LOC(e), defaults);
1245	1245	RETURN_IF_ERROR(codegen_setup_annotations_scope(c, LOC(e), key, name));
1246	1246	if (allow_starred && e->kind == Starred_kind) {
1247		- VISIT(c, expr, e->v.Starred.value);
1248		- ADDOP_I(c, LOC(e), UNPACK_SEQUENCE, (Py_ssize_t)1);
	1247	+ VISIT_IN_SCOPE(c, expr, e->v.Starred.value);
	1248	+ ADDOP_I_IN_SCOPE(c, LOC(e), UNPACK_SEQUENCE, (Py_ssize_t)1);
1249	1249	}
1250	1250	else {
1251		- VISIT(c, expr, e);
	1251	+ VISIT_IN_SCOPE(c, expr, e);
1252	1252	}
1253	1253	ADDOP_IN_SCOPE(c, LOC(e), RETURN_VALUE);
1254	1254	PyCodeObject *co = _PyCompile_OptimizeAndAssemble(c, 1);

0 commit comments

Comments

0 (0)