gh-120155: Fix Coverity issue in parse_string() (#120997) · python/cpython@769aea3 · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 36.1k
• Star 77.2k

• Code
• Issues 5k+
• Pull requests 2.7k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 769aea3

Browse filesBrowse the repository at this point in the historyBrowse files

vstinner

authored

gh-120155: Fix Coverity issue in parse_string() (#120997)

1 parent 2d3187b commit 769aea3
Copy full SHA for 769aea3

1 file changed

+5Lines changed: 5 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Parser
  • string_parser.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Parser/string_parser.c‎

Copy file name to clipboardExpand all lines: Parser/string_parser.c

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -229,9 +229,14 @@ _PyPegen_parse_string(Parser *p, Token *t)
229	229	PyErr_BadInternalCall();
230	230	return NULL;
231	231	}
	232	+
232	233	/* Skip the leading quote char. */
233	234	s++;
234	235	len = strlen(s);
	236	+ // gh-120155: 's' contains at least the trailing quote,
	237	+ // so the code '--len' below is safe.
	238	+ assert(len >= 1);
	239	+
235	240	if (len > INT_MAX) {
236	241	PyErr_SetString(PyExc_OverflowError, "string to parse is too long");
237	242	return NULL;

0 commit comments

Comments

0 (0)