bpo-37651: Document CancelledError is now a subclass of BaseException… · python/cpython@7b69069 · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 36.1k
• Star 77.2k

• Code
• Issues 5k+
• Pull requests 2.7k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7b69069

Browse filesBrowse the repository at this point in the historyBrowse files

tirkarthi

authored and

miss-islington

committed

bpo-37651: Document CancelledError is now a subclass of BaseException (GH-15950)

https://bugs.python.org/issue37651 Automerge-Triggered-By: @1st1

1 parent 97b817e commit 7b69069
Copy full SHA for 7b69069

1 file changed

+2-19Lines changed: 2 additions & 19 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Doc/library
  • asyncio-exceptions.rst

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Doc/library/asyncio-exceptions.rst‎

Copy file name to clipboardExpand all lines: Doc/library/asyncio-exceptions.rst

+2-19Lines changed: 2 additions & 19 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -25,26 +25,9 @@ Exceptions
25	25	when asyncio Tasks are cancelled. In almost all situations the
26	26	exception must be re-raised.
27	27
28		- .. important::
29		-
30		- This exception is a subclass of :exc:`Exception`, so it can be
31		- accidentally suppressed by an overly broad ``try..except`` block::
32		-
33		- try:
34		- await operation
35		- except Exception:
36		- # The cancellation is broken because the *except* block
37		- # suppresses the CancelledError exception.
38		- log.log('an error has occurred')
39		-
40		- Instead, the following pattern should be used::
	28	+ .. versionchanged:: 3.8
41	29
42		- try:
43		- await operation
44		- except asyncio.CancelledError:
45		- raise
46		- except Exception:
47		- log.log('an error has occurred')
	30	+ :exc:`CancelledError` is now a subclass of :class:`BaseException`.
48	31
49	32
50	33	.. exception:: InvalidStateError

0 commit comments

Comments

0 (0)