FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Minor code and comment cleanups. · python/cpython@8dbbae2 · GitHub

Repository navigation

Commit 8dbbae2

Browse files
committed
Minor code and comment cleanups.
1 parent dabbfe7 commit 8dbbae2

1 file changed

Lines changed: 18 additions & 21 deletions

File tree

‎Modules/_collectionsmodule.c‎

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
* And their exact relationship is:
5555
* (d.leftindex + d.len - 1) % BLOCKLEN == d.rightindex
5656
*
57-
* Whenever d.leftblock == d.rightblock,
57+
* Whenever d.leftblock == d.rightblock, then:
5858
* d.leftindex + d.len - 1 == d.rightindex
5959
*
6060
* However, when d.leftblock != d.rightblock, the d.leftindex and
@@ -206,20 +206,20 @@ deque_pop(dequeobject *deque, PyObject *unused)
206206
deque->state++;
207207

208208
if (deque->rightindex == -1) {
209-
if (Py_SIZE(deque) == 0) {
210-
assert(deque->leftblock == deque->rightblock);
211-
assert(deque->leftindex == deque->rightindex+1);
212-
/* re-center instead of freeing a block */
213-
deque->leftindex = CENTER + 1;
214-
deque->rightindex = CENTER;
215-
} else {
209+
if (Py_SIZE(deque)) {
216210
prevblock = deque->rightblock->leftlink;
217211
assert(deque->leftblock != deque->rightblock);
218212
freeblock(deque->rightblock);
219213
CHECK_NOT_END(prevblock);
220214
MARK_END(prevblock->rightlink);
221215
deque->rightblock = prevblock;
222216
deque->rightindex = BLOCKLEN - 1;
217+
} else {
218+
assert(deque->leftblock == deque->rightblock);
219+
assert(deque->leftindex == deque->rightindex+1);
220+
/* re-center instead of freeing a block */
221+
deque->leftindex = CENTER + 1;
222+
deque->rightindex = CENTER;
223223
}
224224
}
225225
return item;
@@ -244,20 +244,20 @@ deque_popleft(dequeobject *deque, PyObject *unused)
244244
deque->state++;
245245

246246
if (deque->leftindex == BLOCKLEN) {
247-
if (Py_SIZE(deque) == 0) {
248-
assert(deque->leftblock == deque->rightblock);
249-
assert(deque->leftindex == deque->rightindex+1);
250-
/* re-center instead of freeing a block */
251-
deque->leftindex = CENTER + 1;
252-
deque->rightindex = CENTER;
253-
} else {
247+
if (Py_SIZE(deque)) {
254248
assert(deque->leftblock != deque->rightblock);
255249
prevblock = deque->leftblock->rightlink;
256250
freeblock(deque->leftblock);
257251
CHECK_NOT_END(prevblock);
258252
MARK_END(prevblock->leftlink);
259253
deque->leftblock = prevblock;
260254
deque->leftindex = 0;
255+
} else {
256+
assert(deque->leftblock == deque->rightblock);
257+
assert(deque->leftindex == deque->rightindex+1);
258+
/* re-center instead of freeing a block */
259+
deque->leftindex = CENTER + 1;
260+
deque->rightindex = CENTER;
261261
}
262262
}
263263
return item;
@@ -300,7 +300,7 @@ static PyObject *
300300
deque_append(dequeobject *deque, PyObject *item)
301301
{
302302
deque->state++;
303-
if (deque->rightindex == BLOCKLEN-1) {
303+
if (deque->rightindex == BLOCKLEN - 1) {
304304
block *b = newblock(Py_SIZE(deque));
305305
if (b == NULL)
306306
return NULL;
@@ -396,7 +396,7 @@ deque_extend(dequeobject *deque, PyObject *iterable)
396396

397397
while ((item = PyIter_Next(it)) != NULL) {
398398
deque->state++;
399-
if (deque->rightindex == BLOCKLEN-1) {
399+
if (deque->rightindex == BLOCKLEN - 1) {
400400
block *b = newblock(Py_SIZE(deque));
401401
if (b == NULL) {
402402
Py_DECREF(item);
@@ -669,7 +669,7 @@ deque_reverse(dequeobject *deque, PyObject *unused)
669669
block *rightblock = deque->rightblock;
670670
Py_ssize_t leftindex = deque->leftindex;
671671
Py_ssize_t rightindex = deque->rightindex;
672-
Py_ssize_t n = (Py_SIZE(deque))/2;
672+
Py_ssize_t n = Py_SIZE(deque) / 2;
673673
Py_ssize_t i;
674674
PyObject *tmp;
675675

@@ -1135,7 +1135,6 @@ deque_repr(PyObject *deque)
11351135
return NULL;
11361136
}
11371137
if (((dequeobject *)deque)->maxlen != -1)
1138-
11391138
result = PyUnicode_FromFormat("deque(%R, maxlen=%zd)",
11401139
aslist, ((dequeobject *)deque)->maxlen);
11411140
else
@@ -1315,8 +1314,6 @@ static PyNumberMethods deque_as_number = {
13151314
0, /* nb_absolute */
13161315
(inquiry)deque_bool, /* nb_bool */
13171316
0, /* nb_invert */
1318-
0, /* nb_lshift */
1319-
0, /* nb_rshift */
13201317
};
13211318

13221319

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL