gh-137586: Open external osascript program with absolute path (GH-137… · python/cpython@a0c57a8 · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 35.3k
• Star 75k

• Code
• Issues 5k+
• Pull requests 2.6k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a0c57a8

Browse filesBrowse the repository at this point in the historyBrowse files

fionn

and

hugovk

authored

gh-137586: Open external osascript program with absolute path (GH-137584)

Open web browser with absolute path On macOS, web browsers are opened via popen calling osascript. However, if a user has a colliding osascript executable earlier in their PATH, this may fail or cause unwanted behaviour. Depending on one's environment or level of paranoia, this may be considered a security vulnerability. Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

1 parent 3d724dd commit a0c57a8
Copy full SHA for a0c57a8

4 files changed

+4-3Lines changed: 4 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Lib
  • test
    • test_webbrowser.py
  • turtledemo
    • __main__.py
  • webbrowser.py
• Misc/NEWS.d/next/macOS
  • 2025-10-17-01-07-03.gh-issue-137586.kVzxvp.rst

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Lib/test/test_webbrowser.py‎

Copy file name to clipboardExpand all lines: Lib/test/test_webbrowser.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -351,7 +351,7 @@ def test_default_open(self):
351	351	url = "https://python.org"
352	352	self.browser.open(url)
353	353	self.assertTrue(self.popen_pipe._closed)
354		- self.assertEqual(self.popen_pipe.cmd, "osascript")
	354	+ self.assertEqual(self.popen_pipe.cmd, "/usr/bin/osascript")
355	355	script = self.popen_pipe.pipe.getvalue()
356	356	self.assertEqual(script.strip(), f'open location "{url}"')
357	357

Collapse file

‎Lib/turtledemo/__main__.py‎

Copy file name to clipboardExpand all lines: Lib/turtledemo/__main__.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -136,7 +136,7 @@ def __init__(self, filename=None):
136	136	# so that our menu bar appears.
137	137	subprocess.run(
138	138	[
139		- 'osascript',
	139	+ '/usr/bin/osascript',
140	140	'-e', 'tell application "System Events"',
141	141	'-e', 'set frontmost of the first process whose '
142	142	'unix id is {} to true'.format(os.getpid()),

Collapse file

‎Lib/webbrowser.py‎

Copy file name to clipboardExpand all lines: Lib/webbrowser.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -656,7 +656,7 @@ def open(self, url, new=0, autoraise=True):
656	656	end
657	657	'''
658	658
659		- osapipe = os.popen("osascript", "w")
	659	+ osapipe = os.popen("/usr/bin/osascript", "w")
660	660	if osapipe is None:
661	661	return False
662	662

Collapse file

‎Misc/NEWS.d/next/macOS/2025-10-17-01-07-03.gh-issue-137586.kVzxvp.rst‎

Copy file name to clipboard

+1Lines changed: 1 addition & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -0,0 +1 @@
	1	+ Invoke :program:`osascript` with absolute path in :mod:`webbrowser` and :mod:`!turtledemo`.

0 commit comments

Comments

0 (0)