gh-120726: Fix compiler warnings on is_core_module() (#120727) · python/cpython@a816cd6 · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 36.1k
• Star 77.2k

• Code
• Issues 5k+
• Pull requests 2.7k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a816cd6

Browse filesBrowse the repository at this point in the historyBrowse files

Eclips4

authored

gh-120726: Fix compiler warnings on is_core_module() (#120727)

Fix compiler warnings on is_core_module() and check_interpreter_whence(): only define them when assertions are built.

1 parent 45d5cab commit a816cd6
Copy full SHA for a816cd6

2 files changed

+5-4Lines changed: 5 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Python
  • import.c
  • pystate.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Python/import.c‎

Copy file name to clipboardExpand all lines: Python/import.c

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1551,6 +1551,7 @@ get_core_module_dict(PyInterpreterState *interp,
1551	1551	return NULL;
1552	1552	}
1553	1553
	1554	+ #ifndef NDEBUG
1554	1555	static inline int
1555	1556	is_core_module(PyInterpreterState *interp, PyObject *name, PyObject *path)
1556	1557	{
@@ -1568,7 +1569,6 @@ is_core_module(PyInterpreterState *interp, PyObject *name, PyObject *path)
1568	1569	}
1569	1570
1570	1571
1571		- #ifndef NDEBUG
1572	1572	static _Py_ext_module_kind
1573	1573	_get_extension_kind(PyModuleDef *def, bool check_size)
1574	1574	{

Collapse file

‎Python/pystate.c‎

Copy file name to clipboardExpand all lines: Python/pystate.c

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -584,9 +584,9 @@ free_interpreter(PyInterpreterState *interp)
584	584	PyMem_RawFree(interp);
585	585	}
586	586	}
587		-
	587	+ #ifndef NDEBUG
588	588	static inline int check_interpreter_whence(long);
589		-
	589	+ #endif
590	590	/* Get the interpreter state to a minimal consistent state.
591	591	Further init happens in pylifecycle.c before it can be used.
592	592	All fields not initialized here are expected to be zeroed out,
@@ -1130,7 +1130,7 @@ _PyInterpreterState_IsReady(PyInterpreterState *interp)
1130	1130	return interp->_ready;
1131	1131	}
1132	1132
1133		-
	1133	+ #ifndef NDEBUG
1134	1134	static inline int
1135	1135	check_interpreter_whence(long whence)
1136	1136	{
@@ -1142,6 +1142,7 @@ check_interpreter_whence(long whence)
1142	1142	}
1143	1143	return 0;
1144	1144	}
	1145	+ #endif
1145	1146
1146	1147	long
1147	1148	_PyInterpreterState_GetWhence(PyInterpreterState *interp)

0 commit comments

Comments

0 (0)