gh-104372: Use non-Raw malloc for c_fds_to_keep in _posixsubprocess (… · python/cpython@d1732fe · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 36.1k
• Star 77.2k

• Code
• Issues 5k+
• Pull requests 2.7k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d1732fe

Browse filesBrowse the repository at this point in the historyBrowse files

gpshead

authored

gh-104372: Use non-Raw malloc for c_fds_to_keep in _posixsubprocess (#104697)

Use non-Raw malloc for c_fds_to_keep as the code could ask for 0 length.

1 parent 68ee8b3 commit d1732fe
Copy full SHA for d1732fe

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Modules
  • _posixsubprocess.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Modules/_posixsubprocess.c‎

Copy file name to clipboardExpand all lines: Modules/_posixsubprocess.c

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1074,7 +1074,7 @@ subprocess_fork_exec_impl(PyObject *module, PyObject *process_args,
1074	1074	#endif /* HAVE_SETREUID */
1075	1075	}
1076	1076
1077		- c_fds_to_keep = PyMem_RawMalloc(fds_to_keep_len * sizeof(int));
	1077	+ c_fds_to_keep = PyMem_Malloc(fds_to_keep_len * sizeof(int));
1078	1078	if (c_fds_to_keep == NULL) {
1079	1079	PyErr_SetString(PyExc_MemoryError, "failed to malloc c_fds_to_keep");
1080	1080	goto cleanup;
@@ -1157,7 +1157,7 @@ subprocess_fork_exec_impl(PyObject *module, PyObject *process_args,
1157	1157
1158	1158	cleanup:
1159	1159	if (c_fds_to_keep != NULL) {
1160		- PyMem_RawFree(c_fds_to_keep);
	1160	+ PyMem_Free(c_fds_to_keep);
1161	1161	}
1162	1162
1163	1163	if (saved_errno != 0) {

0 commit comments

Comments

0 (0)