gh-107967: Fix infinite recursion on invalid escape sequence warning … · python/cpython@d66bc9e · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 36.1k
• Star 77.2k

• Code
• Issues 5k+
• Pull requests 2.7k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d66bc9e

Browse filesBrowse the repository at this point in the historyBrowse files

lysnikolaou

authored

gh-107967: Fix infinite recursion on invalid escape sequence warning (#107968)

1 parent 13c36dc commit d66bc9e
Copy full SHA for d66bc9e

2 files changed

+13Lines changed: 13 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Lib/test
  • test_fstring.py
• Parser
  • tokenizer.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Lib/test/test_fstring.py‎

Copy file name to clipboardExpand all lines: Lib/test/test_fstring.py

+10Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1673,5 +1673,15 @@ def test_debug_in_file(self):
1673	1673	self.assertEqual(stdout.decode('utf-8').strip().replace('\r\n', '\n').replace('\r', '\n'),
1674	1674	"3\n=3")
1675	1675
	1676	+ def test_syntax_warning_infinite_recursion_in_file(self):
	1677	+ with temp_cwd():
	1678	+ script = 'script.py'
	1679	+ with open(script, 'w') as f:
	1680	+ f.write(r"print(f'\{1}')")
	1681	+
	1682	+ _, stdout, stderr = assert_python_ok(script)
	1683	+ self.assertIn(rb'\1', stdout)
	1684	+ self.assertEqual(len(stderr.strip().splitlines()), 2)
	1685	+
1676	1686	if __name__ == '__main__':
1677	1687	unittest.main()

Collapse file

‎Parser/tokenizer.c‎

Copy file name to clipboardExpand all lines: Parser/tokenizer.c

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1539,6 +1539,9 @@ parser_warn(struct tok_state *tok, PyObject *category, const char *format, ...)
1539	1539	static int
1540	1540	warn_invalid_escape_sequence(struct tok_state *tok, int first_invalid_escape_char)
1541	1541	{
	1542	+ if (!tok->report_warnings) {
	1543	+ return 0;
	1544	+ }
1542	1545
1543	1546	PyObject *msg = PyUnicode_FromFormat(
1544	1547	"invalid escape sequence '\\%c'",

0 commit comments

Comments

0 (0)