bpo-40474: Updated coverage.yml to better report coverage stats (#19851) · python/cpython@d9c1f19 · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 35.3k
• Star 75k

• Code
• Issues 5k+
• Pull requests 2.6k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit d9c1f19

Browse filesBrowse the repository at this point in the historyBrowse files

lrjball

authored

bpo-40474: Updated coverage.yml to better report coverage stats (#19851)

Currently modules which are imported early are misreported in coverage. A fix is documented in the devguide, but the fix wasn't being used in CI.

1 parent cfc6ce4 commit d9c1f19
Copy full SHA for d9c1f19

2 files changed

+4Lines changed: 4 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • coverage.yml
• .travis.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/coverage.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/coverage.yml

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -52,6 +52,7 @@ jobs:
52	52	python -m pip install -U coverage
53	53	python -m pip install -r Misc/requirements-test.txt
54	54	python -m test.pythoninfo
	55	+ export PYTHONPATH=`find .venv -name fullcoverage`
55	56	- name: 'Tests with coverage'
56	57	run: >
57	58	source ./.venv/bin/activate &&
@@ -67,6 +68,7 @@ jobs:
67	68	|| true
68	69	- name: 'Publish code coverage results'
69	70	run: |
	71	+ export PYTHONPATH=
70	72	source ./.venv/bin/activate
71	73	bash <(curl -s https://codecov.io/bash) -y .github/codecov.yml
72	74	env:

Collapse file

‎.travis.yml‎

Copy file name to clipboardExpand all lines: .travis.yml

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -89,11 +89,13 @@ matrix:
89	89	- ./venv/bin/python -m pip install -U coverage
90	90	- ./venv/bin/python -m pip install -r Misc/requirements-test.txt
91	91	- ./venv/bin/python -m test.pythoninfo
	92	+ - export PYTHONPATH=`find venv -name fullcoverage`
92	93	script:
93	94	# Skip tests that re-run the entire test suite.
94	95	- xvfb-run ./venv/bin/python -m coverage run --branch --pylib -m test --fail-env-changed -uall,-cpu -x test_multiprocessing_fork -x test_multiprocessing_forkserver -x test_multiprocessing_spawn -x test_concurrent_futures || true
95	96	after_script: # Probably should be after_success once test suite updated to run under coverage.py.
96	97	# Make the `coverage` command available to Codecov w/ a version of Python that can parse all source files.
	98	+ - export PYTHONPATH=
97	99	- source ./venv/bin/activate
98	100	- bash <(curl -s https://codecov.io/bash) -y .github/codecov.yml
99	101	- name: "Test code coverage (C)"

0 commit comments

Comments

0 (0)