[3.11] gh-107963: Fix set_forkserver_preload to check the type of giv… · python/cpython@db4400b · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 36.1k
• Star 77.2k

• Code
• Issues 5k+
• Pull requests 2.7k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit db4400b

Browse filesBrowse the repository at this point in the historyBrowse files

miss-islington

and

corona10

authored

[3.11] gh-107963: Fix set_forkserver_preload to check the type of given list (GH-107965) (gh-107976)

gh-107963: Fix set_forkserver_preload to check the type of given list (GH-107965) (cherry picked from commit 6515ec3) gh-107963: Fix set_forkserver_preload to check the type of given list Co-authored-by: Dong-hee Na <donghee.na@python.org>

1 parent e2420c5 commit db4400b
Copy full SHA for db4400b

3 files changed

+11-1Lines changed: 11 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Lib
  • multiprocessing
    • forkserver.py
  • test
    • _test_multiprocessing.py
• Misc/NEWS.d/next/Library
  • 2023-08-15-18-20-00.gh-issue-107963.20g5BG.rst

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Lib/multiprocessing/forkserver.py‎

Copy file name to clipboardExpand all lines: Lib/multiprocessing/forkserver.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -61,7 +61,7 @@ def _stop_unlocked(self):
61	61
62	62	def set_forkserver_preload(self, modules_names):
63	63	'''Set list of module names to try to load in forkserver process.'''
64		- if not all(type(mod) is str for mod in self._preload_modules):
	64	+ if not all(type(mod) is str for mod in modules_names):
65	65	raise TypeError('module_names must be a list of strings')
66	66	self._preload_modules = modules_names
67	67

Collapse file

‎Lib/test/_test_multiprocessing.py‎

Copy file name to clipboardExpand all lines: Lib/test/_test_multiprocessing.py

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -5293,6 +5293,14 @@ def test_context(self):
5293	5293	self.assertRaises(ValueError, ctx.set_start_method, None)
5294	5294	self.check_context(ctx)
5295	5295
	5296	+ def test_context_check_module_types(self):
	5297	+ try:
	5298	+ ctx = multiprocessing.get_context('forkserver')
	5299	+ except ValueError:
	5300	+ raise unittest.SkipTest('forkserver should be available')
	5301	+ with self.assertRaisesRegex(TypeError, 'module_names must be a list of strings'):
	5302	+ ctx.set_forkserver_preload([1, 2, 3])
	5303	+
5296	5304	def test_set_get(self):
5297	5305	multiprocessing.set_forkserver_preload(PRELOAD)
5298	5306	count = 0

Collapse file

‎Misc/NEWS.d/next/Library/2023-08-15-18-20-00.gh-issue-107963.20g5BG.rst‎

Copy file name to clipboard

+2Lines changed: 2 additions & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,2 @@
	1	+ Fix :func:`multiprocessing.set_forkserver_preload` to check the given list
	2	+ of modules names. Patch by Dong-hee Na.

0 commit comments

Comments

0 (0)