Repository navigation
Commit eba449a
authored
While CPython doesn't support `--enable-wasm-dynamic-linking`, external tools like componentize-py do and they have to patch around it. Since the flag is off by default, allowing the flag so external users can add/inject dynamic linking support seems acceptable.
1 parent d49e6f3 commit eba449a
3 files changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,3 @@ | |||
| 1 | + Allow ``--enable-wasm-dynamic-linking`` for WASI. While CPython doesn't | ||
| 2 | + directly support it so external/downstream users do not have to patch in | ||
| 3 | + support for the flag. | ||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1323,11 +1323,11 @@ dnl See https://emscripten.org/docs/compiling/Dynamic-Linking.html | |||
| 1323 | 1323 | AC_MSG_CHECKING([for --enable-wasm-dynamic-linking]) | |
| 1324 | 1324 | AC_ARG_ENABLE([wasm-dynamic-linking], | |
| 1325 | 1325 | [AS_HELP_STRING([--enable-wasm-dynamic-linking], | |
| 1326 | - [Enable dynamic linking support for WebAssembly (default is no)])], | ||
| 1326 | + [Enable dynamic linking support for WebAssembly (default is no); WASI requires an external dynamic loader to handle imports])], | ||
| 1327 | 1327 | [ | |
| 1328 | 1328 | AS_CASE([$ac_sys_system], | |
| 1329 | 1329 | [Emscripten], [], | |
| 1330 | - [WASI], [AC_MSG_ERROR([WASI dynamic linking is not implemented yet.])], | ||
| 1330 | + [WASI], [], | ||
| 1331 | 1331 | [AC_MSG_ERROR([--enable-wasm-dynamic-linking only applies to Emscripten and WASI])] | |
| 1332 | 1332 | ) | |
| 1333 | 1333 | ], [ | |
0 commit comments