bpo-46417: Revert remove_subclass() change (GH-30750) · python/cpython@fda8886 · GitHub

python / cpython Public

• Notifications You must be signed in to change notification settings
• Fork 35.3k
• Star 75k

• Code
• Issues 5k+
• Pull requests 2.6k
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fda8886

Browse filesBrowse the repository at this point in the historyBrowse files

vstinner

authored

bpo-46417: Revert remove_subclass() change (GH-30750)

remove_subclass() doesn't clear the tp_subclasses dict if the dict becomes empty.

1 parent 595225e commit fda8886
Copy full SHA for fda8886

1 file changed

-4Lines changed: 0 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Objects
  • typeobject.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Objects/typeobject.c‎

Copy file name to clipboardExpand all lines: Objects/typeobject.c

-4Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -6553,10 +6553,6 @@ remove_subclass(PyTypeObject *base, PyTypeObject *type)
6553	6553	PyErr_Clear();
6554	6554	}
6555	6555	Py_XDECREF(key);
6556		-
6557		- if (PyDict_Size(dict) == 0) {
6558		- Py_CLEAR(base->tp_subclasses);
6559		- }
6560	6556	}
6561	6557
6562	6558	static void

0 commit comments

Comments

0 (0)