FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make `os.DirEntry.is_symlink` ~twice as fast · Issue #108985 · python/cpython · GitHub

Repository navigation

Make os.DirEntry.is_symlink ~twice as fast #108985

Closed as not planned
Closed as not planned

Description

While fixing a merge conflict in #108718 I've noticed that I've missed the same problem in os.DirEntry.is_symlink.

I will send a new PR since the original one was already merged

Refs #108717

Linked PRs

Activity

  1. self-assigned this
    on Sep 6, 2023
  2. added a commit that references this issue on Sep 6, 2023
  3. sobolevn commented on Sep 6, 2023

    MemberAuthor

    False alarm:

    #elif defined(HAVE_DIRENT_D_TYPE)
        /* POSIX */
        if (self->d_type != DT_UNKNOWN)
            return self->d_type == DT_LNK;
        else
            return DirEntry_test_mode(defining_class, self, 0, S_IFLNK);
    #else
        /* POSIX without d_type */
        return DirEntry_test_mode(defining_class, self, 0, S_IFLNK);
    #endif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

extension-modulesC modules in the Modules dirperformancePerformance or resource usage

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


    Back | FazBrowse Home | New Git URL