Incorrect rendering of `replace` method in `copy` docs: consider adding `copy.SupportsReplace`? · Issue #109961 · python/cpython · GitHub

Bug report

Here's how it looks right now:

Link: https://docs.python.org/dev/library/copy.html

But, there's no such thing as copy.__replace__.

There are several options:

Do not document this as a method (however, it is)
Document it as object.__replace__, but object does not have this method - it can be very confusing
Add some protocol, like typing.SupportsReplace and document SupportsReplace.__replace__

I personally think that typing.SupportsReplace is very useful on its own, because:

we will use it in typeshed for typing copy.replace
it can be used in other places by end users
it matches exactly what __replace__ is: a protocol

So, it can something like:

class SupportsReplace(Protocol):
    def __replace__(self, /, **kwargs: Any) -> Self: ...

We cannot really type **kwargs here. See https://discuss.python.org/t/generalize-replace-function/28511/20 But, we can later apply mypy plugin similar to one we use for dataclasses.replace: https://github.com/python/mypy/blob/4b66fa9de07828621fee1d53abd533f3903e570a/mypy/plugins/dataclasses.py#L390-L402

I would like to work on docs / implementation changes after we discuss all the things and come to an agreement :)

CC @serhiy-storchaka @AlexWaygood

Linked PRs

We should document this in the datamodel, similar to __buffer__, which is also only applicable in certain cases.

A

I like the idea of SupportsReplace. I think it should be added to the copy module, though, not typing, similar to how PathLike is in the os module and AbstractContextManager is in contextlib.

We can take the same approach we do with os.PathLike and contextlib.AbstractContextManager in order to avoid importing typing in those modules: have it be an abc.ABC at runtime, but special-case it in typing so that it behaves like a protocol (and pretend in typeshed that it is a protocol). That gives us the best of both worlds.

Yes, I agree with copy module. This way it would be also more convenient for users:

from copy import replace, SupportsReplace

Minor, but perhaps consider Replaceable? That's more in line with the collections ABCs.

A

Minor, but perhaps consider Replaceable? That's more in line with the collections ABCs.

I think I prefer Nikita's name, which is inline with the Supports* naming convention in the typing module -- SupportsInt, SupportsFloat, etc. "Replaceable" feels like you're making some comment about the fungibility of the object in question, which isn't necessarily true ;)

Fair enough -- the suggestion was in large part as currently it is only the typing module which uses the SupportsDunder convention. Outwith typing, the following usages appear:

typing.Protocol subclasses. All of the following are 'complex' protocols with multiple attributes, save for _Readable, which only defines the read() method.
- importlib.metadata.{PackageMetadata,SimplePath}
- importlib.resources.abc.Traversable
- wsgiref.types.{StartResponse,InputStream,ErrorStream,_Readable,FileWrapper}
abc.ABC subclasses or abc.ABCMeta subclasses. Contrary to my earlier note, it seems only 6 of the collections.abc types are named -ble. However, these 6 form a plurality of the 'single method' types (rounding out the set are Buffer, Container, Sized, PathLike, and various number types.
- collections.abc.{Awaitable,AsyncIterable,Hashable,Iterable,Reversible,Callable }
- collections.abc.{AsyncGenerator,AsyncIterator,Buffer,ByteString,Collection,Container,Coroutine,Generator,ItemsView,Iterator,KeysView,Mapping,MappingView,MutableMapping,MutableSequence,MutableSet,Sequence,Set,Sized,ValuesView}
- contextlib.{AbstractContextManager,AbstractAsyncContextManager}
- importlib.resources.simple.SimpleReader
- multiprocessing.reduction.AbstractReducer
- numbers.Number (& by extension the whole numeric tower)
- os.PathLike
- selectors.BaseSelector

So it seems consistency is not quite here! I think I sympathise most with your fungability argument, given that this replaces data within the object, not the object itself--though for immutable types the object will be replaced!

A

Yes: objects with the __replace__ method may be fungible, but aren't necessarily fungible :)

Thank you for catching this @sobolevn.

I think adding object. would be enough. There are no SupportCopy, SupportDeepCopy or SupportPickle. While currently copy.replace() only supports classes with __replace__ method, in future it may support other objects. For example it could support pure Python classes without __new__ and __init__ methods, or some pickleable classes. For now it requires the __replace__ method, but after it became widely used we can analyze patterns of its use and make defining trivial __replace__ methods unneeded.

While currently copy.replace() only supports classes with __replace__ method, in future it may support other objects. For example it could support pure Python classes without __new__ and __init__ methods, or some pickleable classes. For now it requires the __replace__ method, but after it became widely used we can analyze patterns of its use and make defining trivial __replace__ methods unneeded.

Ah, if that's the intention, then adding SupportsReplace would indeed be a bad idea.

pythongh-109961: Fix incorrect rendering of `__replace__` in `library…

gh-109961: Docs: Fix incorrect rendering of `__replace__` in `copy.rs…

pythongh-109961: Use proper `module` for `copy` method docs

pythongh-109961: Docs: Fix incorrect rendering of `__replace__` in `c…

gh-109961: Use proper `module` for `copy` method docs (#110027)

Can it be closed already?

pythongh-109961: Docs: Fix incorrect rendering of `__replace__` in `c…

pythongh-109961: Use proper `module` for `copy` method docs (python#1…

[3.12] pythongh-109961: Docs: Fix incorrect rendering of `__replace__…

[3.12] gh-109961: Docs: Fix incorrect rendering of `__replace__` in `…

Incorrect rendering of `replace` method in `copy` docs: consider adding `copy.SupportsReplace`? · Issue #109961 · python/cpython · GitHub

Repository navigation

Incorrect rendering of replace method in copy docs: consider adding copy.SupportsReplace? #109961

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Incorrect rendering of `__replace__` method in `copy` docs: consider adding `copy.SupportsReplace`? · Issue #109961 · python/cpython · GitHub

Repository navigation

Incorrect rendering of __replace__ method in copy docs: consider adding copy.SupportsReplace? #109961

Description

Bug report

Linked PRs

Activity

AA-Turner commented on Sep 27, 2023

AlexWaygood commented on Sep 27, 2023

sobolevn commented on Sep 27, 2023

AA-Turner commented on Sep 27, 2023

AlexWaygood commented on Sep 27, 2023

AA-Turner commented on Sep 27, 2023

AlexWaygood commented on Sep 27, 2023

serhiy-storchaka commented on Sep 27, 2023

AlexWaygood commented on Sep 27, 2023

serhiy-storchaka commented on Oct 7, 2023

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Incorrect rendering of `replace` method in `copy` docs: consider adding `copy.SupportsReplace`? · Issue #109961 · python/cpython · GitHub

Incorrect rendering of replace method in copy docs: consider adding copy.SupportsReplace? #109961