FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-113174: Sync with importlib_metadata 7.0 by jaraco · Pull Request #113175 · python/cpython · GitHub

/ cpython Public

gh-113174: Sync with importlib_metadata 7.0 - #113175

Merged
jaraco merged 8 commits into
python:mainfrom
jaraco:feature/113174-importlib-metadata-7.0
Dec 21, 2023
ConversationCommits (8)ChecksFiles changed
Merged

gh-113174: Sync with importlib_metadata 7.0#113175
jaraco merged 8 commits into
python:mainfrom
jaraco:feature/113174-importlib-metadata-7.0

Conversation

jaraco commented Dec 15, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Dec 15, 2023
Closed
1 task

hugovk commented Dec 15, 2023

Copy link
Copy Markdown
Member

Sync with importlib_metadata 7.0, including improved type annotations, fixed
issue with symlinked packages in package_distributions, added
EntryPoints.__repr__, introduced the diagnose script, added
Distribution.origin property, and removed deprecated EntryPoint
access by numeric index (tuple behavior).

Will there be docs changes in this PR or another?

jaraco commented Dec 15, 2023

Copy link
Copy Markdown
Member Author

Will there be docs changes in this PR or another?

I've added docs in b610b6d. I chose not to mention some of the changes as they seemed incidental enough not to affect most users.

jaraco marked this pull request as ready for review December 15, 2023 15:13
hugovk reviewed Dec 15, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would this also benefit from an entry in What's New in Python 3.13?

Comment thread Doc/library/importlib.metadata.rst Outdated
Comment thread Doc/library/importlib.metadata.rst Outdated
Comment thread Doc/library/importlib.metadata.rst Outdated
jaraco force-pushed the feature/113174-importlib-metadata-7.0 branch from 5914c78 to aa23e5a Compare December 15, 2023 16:16

jaraco commented Dec 15, 2023

Copy link
Copy Markdown
Member Author

Would this also benefit from an entry in What's New in Python 3.13?

Perhaps. I'd consider mentioning the EntryPoint.__getitem__ removal and new Distribution.origin property, though I expect most users not to care much. Overall, I'm thinking it'd be more noise than value, so I'll propose not to add anything, but I'd be happy to add something if anyone feels otherwise.

AlexWaygood reviewed Dec 19, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I agree with @hugovk that the removal of EntryPoint.__getitem__ should be mentioned in "What's New". It doesn't need to be a prominent mention near the top of the document, but we should try to make sure that all backwards-incompatible changes are mentioned somewhere in that document, in my opinion.

Comment thread Doc/library/importlib.metadata.rst Outdated
brettcannon removed their request for review December 19, 2023 19:18
AlexWaygood reviewed Dec 21, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Outdated

jaraco commented Dec 21, 2023

Copy link
Copy Markdown
Member Author

Today I learned about the syntax (docs). The exclamation point means to ignore EntryPoint because it isn't documented.

jaraco commented Dec 21, 2023

Copy link
Copy Markdown
Member Author

Thanks for the review. Merging, but happy to revisit if needed.

jaraco merged commit 2d91409 into python:main Dec 21, 2023
jaraco deleted the feature/113174-importlib-metadata-7.0 branch December 21, 2023 20:04
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)
8b200cb 
* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

ambv commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

There's some tests that are failing on Windows for this change. The build that introduced the failure is the one with this PR merged:
https://buildbot.python.org/all/#/builders/1079/builds/3009

ambv commented Jan 14, 2024

Copy link
Copy Markdown
Contributor

I worked around the problem by enabling SeCreateSymbolicLinkPrivilege for the buildbot user, but ultimately I believe the test should be skipped for users without this privilege set.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)
7700035 
* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)
8fa3c93 
* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)
6daac7f 
* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
hugovk mentioned this pull request Mar 30, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
AlexWaygood AlexWaygood left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL