| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@gvanrossum -- This might cause an issue with the flow control of the transport. Since the buffer size is calculated with only the payload (and not the entire datagram). The write buffer could in theory be flooded with zero-length datagrams, and the high watermark will never be crossed. cpython/Lib/asyncio/selector_events.py Line 1279 in 67d6bed |
Sorry, something went wrong.
Oh, that's a very good point. I think we could add a constant value to the "buffer size" for each packet added -- the only use for the buffer size is to interact with flow control. In fact, after skimming the UDP Wikipedia page, I think we can add 8 for each packet, since that's the protocol's header size. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, but let's do something about flow control first.
Sorry, something went wrong.
There was a problem hiding this comment.
LG -- I'll merge now!
Sorry, something went wrong.
|
Sorry, I'd like one more doc change. The code and docs are actually fine, but I feel this deserves a What's New entry (Doc/whatsnew/3.13.rst). A bullet in the existing asyncio section under "Improved Modules" should suffice. I'd like it to mention both the ability to send 0-length packets and the change to buffer size (since it can affect details around flow control). Probably a good idea to mention the latter in the news file too. |
Sorry, something went wrong.
|
No worries :) Let me know what you think of this wording I just added! |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks! Will merge later tonight.
Sorry, something went wrong.
|
Sorry Guido, just pushed a documentation change to for the version change note in the Documentation Edit: Also pushed a typo fix (repeated "will now") sorry! |
Sorry, something went wrong.
…ython#115199) Also include the UDP packet header sizes (8 bytes per packet) in the buffer size reported to the flow control subsystem.
…ython#115199) Also include the UDP packet header sizes (8 bytes per packet) in the buffer size reported to the flow control subsystem.
…ython#115199) Also include the UDP packet header sizes (8 bytes per packet) in the buffer size reported to the flow control subsystem.
| Back | FazBrowse Home | New Git URL |
Update DatagramTransport.sendto method to not return when data is an empty bytes object. This allows users to send zero-length datagrams (used for example in Time Protocol RFC 868).
📚 Documentation preview 📚: https://cpython-previews--115199.org.readthedocs.build/