FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-111744: Make `breakpoint()` enter the debugger immediately by gaogaotiantian · Pull Request #118579 · python/cpython · GitHub

/ cpython Public

gh-111744: Make breakpoint() enter the debugger immediately - #118579

Merged
brandtbucher merged 6 commits into
python:mainfrom
gaogaotiantian:pdb-breakpoint
May 5, 2024
ConversationCommits (6)ChecksFiles changed
Merged

gh-111744: Make breakpoint() enter the debugger immediately#118579
brandtbucher merged 6 commits into
python:mainfrom
gaogaotiantian:pdb-breakpoint

Conversation

gaogaotiantian commented May 4, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

We had some discussion in #111744 and in discord channel. We know this is a breaking change but people agree it's much more intuitive.

This basically changes the breakpoint() and pdb.set_trace() behavior so it stops immediately after the call, rather than before the next line.

Unfortunately a lot of the test cases need to be adapted.

📚 Documentation preview 📚: https://cpython-previews--118579.org.readthedocs.build/

bedevere-app Bot mentioned this pull request May 4, 2024
Closed

brandtbucher commented May 4, 2024

Copy link
Copy Markdown
Member

this is a breaking change

Haha.

Away from my computer now, but I’ll take a look at this today.

brandtbucher self-assigned this May 4, 2024

gaogaotiantian commented May 4, 2024

Copy link
Copy Markdown
Member Author

this is a breaking change

Haha.

Pun is actually not intended. Took me a second to realize what's funny :)

ambv commented May 4, 2024

Copy link
Copy Markdown
Contributor

This is a breaking change but I can't tell you how many times I wanted to look at the state of a function, I put breakpoint() at the last line... and it stopped after leaving the function altogether 😵‍💫

So this is great to see!

brandtbucher reviewed May 4, 2024
View reviewed changes
Comment thread Lib/bdb.py
brandtbucher reviewed May 4, 2024
View reviewed changes
Comment thread Doc/library/pdb.rst Outdated

brandtbucher commented May 4, 2024

Copy link
Copy Markdown
Member

Test changes look good. Thanks for applying a variety of fixes there.

brandtbucher approved these changes May 4, 2024
View reviewed changes

brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for this! I'll leave it open for a bit in case others have thoughts.

brandtbucher merged commit 5a0022a into python:main May 5, 2024
gaogaotiantian deleted the pdb-breakpoint branch May 5, 2024 17:15
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
pythonGH-111744: Make breakpoint() enter the debugger immediately (py…
75c1dc2 
…thonGH-118579)
Viicos mentioned this pull request Nov 27, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher approved these changes

Assignees

brandtbucher

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL