gh-119740: Remove deprecated trunc delegation - #119743
Merged
mdickinson merged 18 commits intoJun 2, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
Doc/library/functions.rst
Outdated
Comment thread
Doc/reference/datamodel.rst
Outdated
Comment thread
Doc/library/functions.rst
Outdated
Comment thread
Doc/whatsnew/3.14.rst
Outdated
serhiy-storchaka
approved these changes
May 30, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, something went wrong.
picnixz
reviewed
May 30, 2024
Copy link
Copy Markdown
Member
Author
|
Thanks for the comments; I'll address before merging (but it may take me a few days to get to it). |
Sorry, something went wrong.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
mdickinson
commented
Jun 2, 2024
Comment thread
Doc/whatsnew/3.14.rst
Outdated
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
mdickinson
commented
Jun 2, 2024
Comment thread
Doc/reference/datamodel.rst
Outdated
serhiy-storchaka
approved these changes
Jun 2, 2024
Copy link
Copy Markdown
Member
Author
|
Updating for merge conflicts ... |
Sorry, something went wrong.
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`. --------- Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`. --------- Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Remove the delegation of `int` to the `__trunc__` special method: `int` will now only delegate to `__int__` and `__index__` (in that order). `__trunc__` continues to exist, but its sole purpose is to support `math.trunc`. --------- Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
skirpichev
added a commit
to skirpichev/cpython
that referenced
this pull request
Feb 9, 2026
This was done in python#119743 (3.14).
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 9, 2026
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 9, 2026
…on (pythonGH-144622) This was done in pythonGH-119743 (3.14). (cherry picked from commit aa6ed80) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 9, 2026
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
…on (pythonGH-144622) This was done in pythonGH-119743 (3.14).
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…on (pythonGH-144622) This was done in pythonGH-119743 (3.14).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the delegation of int to the __trunc__ special method: int will now only delegate to __int__ and __index__ (in that order). __trunc__ continues to exist, but its sole purpose is to support math.trunc.
📚 Documentation preview 📚: https://cpython-previews--119743.org.readthedocs.build/