Repository navigation
Simplify consumers by making queue.Queue an iterable #120499
Description
Feature or enhancement
Proposal:
class Iterator:
def __init__(self, queue):
self.queue = queue
def __iter__(self):
return self
async def __next__(self):
try:
return self.queue.get_nowait()
except (Empty, ShutDown):
raise StopIteration
class Queue:
...
def __iter__(self):
return Iterator(self)Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Activity
sobolevn commented on Jun 14, 2024
Sorry, I might be missing something obvious, but can you please explain a motivation behind this change?
zware commented on Jun 14, 2024
@nineteendo, please stop editing your posts after submission. Edit before you submit, and don't submit until you aren't going to change it again. There is not a window in which substantial edits are okay; email notifications will only ever contain the original version, which at this point is much different than what is now here.
nineteendo commented on Jun 14, 2024
Guido suggested this here: python/peps#3782 (comment)
I've made a separate issue, because the title didn't match.
Reverted. I realised we didn't need a separate class, so that's why I use generator in the PR.
Would you prefer me to create a new issue then?
sobolevn commented on Jun 14, 2024
@nineteendo thank you! Please, next time include this context in the issue :)
zware commented on Jun 14, 2024
No, I would prefer that you stop editing your posts :). Not even to revert previous edits, just no more edits.
My suggestion to edit before submission is intended for any post you make, not just new issues. Make sure you're saying what you want to say on the first try; there's no benefit to saying the wrong thing quickly when you have unlimited time to get it right. If your understanding of something changes, say so in a new message.
nineteendo commented on Jun 15, 2024
In the future I'll try to create an issue and PR on my own fork first. I don't make significant changes to regular comments (just fixing a typo or suggestion).
nineteendo commented on Jun 15, 2024
@Zac-HD, multiprocessing.Queue.close() doesn't prevent other processes from putting items on the queue.
So, I'm not sure how we can make this work without a sentinel for every reading process.