GH-99749: Add optional feature to suggest correct names (ArgumentParser) - #124456
Merged
serhiy-storchaka merged 54 commits intoOct 17, 2024
Merged
GH-99749: Add optional feature to suggest correct names (ArgumentParser)#124456serhiy-storchaka merged 54 commits into
serhiy-storchaka merged 54 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Sep 26, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
This PR slightly conflicts with #117766. After merging one of them, the other one should be updated. I am not sure what of them should be merged first.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
A fix should definitely precede a new feature. |
Sorry, something went wrong.
Comment thread
Lib/test/test_argparse.py
Comment thread
Misc/NEWS.d/next/Library/2024-09-24-18-49-16.gh-issue-99749.gBDJX7.rst
Outdated
…DJX7.rst Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
approved these changes
Oct 17, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
serhiy-storchaka
pushed a commit
that referenced
this pull request
Oct 19, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
JelleZijlstra
added a commit
to python/typeshed
that referenced
this pull request
May 12, 2025
…13947) These are - `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302 - `color`, added by python/cpython#132323 Co-authored-by: Sebastian Rittau <srittau@rittau.biz> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
…ython#13947) These are - `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302 - `color`, added by python/cpython#132323 Co-authored-by: Sebastian Rittau <srittau@rittau.biz> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR carries #99773 forward with the original author's go-ahead (thanks @abdulrafey38!). This adds the ability for ArgumentParser to offer suggestions for mistyped argument choices or subparser names. This PR adds this as an optional feature via the suggest_on_error param (default: False).
I have opted to not make this configurable at the subparser or argument level and instead at the parser level to keep this simple. We could consider additional granularity but I'm not convinced that this is required at this time.
📚 Documentation preview 📚: https://cpython-previews--124456.org.readthedocs.build/