Repository navigation
test_ssl: non_linux_skip_if_other_okay_error assumes err.reason is a string #126499
Description
Recently, test_ssl has been failing intermittently but frequently on macOS buildbots, see for example here.
Since #108315, there's some code to skip tests, which does getattr(err, "reason", "") on an arbitrary exception and expects that to be a string. If reason is set to None, a regex search on it fails. This prevents the calling test from checking that the error is correct.
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ssl.py", line 5085, in test_preauth_data_to_tls_server
self.non_linux_skip_if_other_okay_error(wrap_error)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ssl.py", line 5032, in non_linux_skip_if_other_okay_error
re.search('wrong.version.number', getattr(err, "reason", ""), re.I)):
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/re/__init__.py", line 177, in search
return _compile(pattern, flags).search(string)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
TypeError: expected string or bytes-like object, got 'NoneType'I'll send a PR soon.
Activity
pythongh-126499: test_ssl: Don't assume err.reason is a string
gh-126499: test_ssl: Don't assume err.reason is a string (GH-126501)
encukou commented on Nov 7, 2024
I'll watch the buildbot for a day or two before backporting the fix.
pythongh-126499: test_ssl: Don't assume err.reason is a string (pytho…
pythongh-126499: test_ssl: Don't assume err.reason is a string (pytho…
[3.13] gh-126499: test_ssl: Don't assume err.reason is a string (GH-1…
[3.12] gh-126499: test_ssl: Don't assume err.reason is a string (GH-1…
pythongh-126499: test_ssl: Don't assume err.reason is a string (pytho…
pythongh-126499: test_ssl: Don't assume err.reason is a string (pytho…