GH-127133: Remove ability to nest argument groups & mutually exclusive groups - #127186
Merged
iritkatriel merged 12 commits intoNov 24, 2024
Merged
GH-127133: Remove ability to nest argument groups & mutually exclusive groups#127186iritkatriel merged 12 commits into
iritkatriel merged 12 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
Lib/argparse.py
Outdated
Copy link
Copy Markdown
Member
Author
|
@iritkatriel Perhaps you can take a look at this one if you've got bandwidth, since you added the original deprecation warnings ☺️ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Hmm, let me double-check that there aren't other formatting simplifications we can make now as a result of dropping this. I took a look and ran branch coverage with a couple of different programs, and nothing stood out to me, so I think it's fine to proceed with this and then tackle any other potential refactorings in separate PRs. |
Sorry, something went wrong.
savannahostrowski
marked this pull request as draft
November 23, 2024 05:07
savannahostrowski
marked this pull request as ready for review
November 23, 2024 06:06
iritkatriel
reviewed
Nov 23, 2024
Comment thread
Lib/test/test_argparse.py
Outdated
Comment thread
Lib/argparse.py
Outdated
Comment thread
Lib/argparse.py
Outdated
Comment thread
Doc/library/argparse.rst
Outdated
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel
approved these changes
Nov 24, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the ability to:
We have been warning users of this deprecation since 3.11.
📚 Documentation preview 📚: https://cpython-previews--127186.org.readthedocs.build/