FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127629: Add ctypes to the Emscripten build by hoodmane · Pull Request #127683 · python/cpython · GitHub

/ cpython Public

gh-127629: Add ctypes to the Emscripten build - #127683

Merged
freakboy3742 merged 6 commits into
python:mainfrom
hoodmane:emscripten-ctypes
Dec 10, 2024
ConversationCommits (6)ChecksFiles changed
Merged

gh-127629: Add ctypes to the Emscripten build#127683
freakboy3742 merged 6 commits into
python:mainfrom
hoodmane:emscripten-ctypes

Conversation

hoodmane commented Dec 6, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Dec 6, 2024
Closed
hoodmane removed the request for review from brettcannon December 6, 2024 11:47
freakboy3742 requested changes Dec 9, 2024
View reviewed changes

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Functionally, this works fine; a couple of questions inline about documentation and gross structure.

Comment thread Tools/wasm/emscripten/__main__.py Outdated
Comment thread Tools/wasm/emscripten/__main__.py
Comment thread Tools/wasm/emscripten/__main__.py

bedevere-app Bot commented Dec 9, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

hoodmane commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again. Thanks @freakboy3742!

bedevere-app Bot commented Dec 9, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

bedevere-app Bot requested a review from freakboy3742 December 9, 2024 19:06
freakboy3742 approved these changes Dec 10, 2024
View reviewed changes

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍 Thanks for those fixes - this looks great!

freakboy3742 merged commit 3b18af9 into python:main Dec 10, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127629: Add ctypes to the Emscripten build (python#127683)
655b380 
Adds tooling to build libffi and add ctypes to the stdlib for Emscripten.
MichaelBuhler reviewed Apr 8, 2025
View reviewed changes
Comment thread Tools/wasm/emscripten/make_libffi.sh
export EM_PKG_CONFIG_PATH="$PKG_CONFIG_PATH"

# Specific variables for cross-compilation
export CHOST="wasm32-unknown-linux" # wasm32-unknown-emscripten

MichaelBuhler Apr 8, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why did this end up being wasm32-unknown-linux instead of wasm32-unknown-emscripten?

hoodmane Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good question. Maybe I put it that way while debugging and didn't notice before merging.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

freakboy3742 freakboy3742 approved these changes
+1 more reviewer
MichaelBuhler MichaelBuhler left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OS-emscripten

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL