gh-125377: Improve tab indentation for pdb multi-line input - #130471
Merged
gaogaotiantian merged 6 commits intoMar 4, 2025
Merged
gh-125377: Improve tab indentation for pdb multi-line input#130471gaogaotiantian merged 6 commits into
gaogaotiantian merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tomasr8
reviewed
Feb 22, 2025
Comment thread
Lib/test/test_pdb.py
Outdated
tomasr8
approved these changes
Feb 23, 2025
iritkatriel
reviewed
Mar 3, 2025
| @@ -0,0 +1 @@ | |||
| ``<tab>`` at the beginning of the line in :mod:`pdb` multi-line input will fill in a 4-space indentation now, instead of inserting a ``\t`` character. | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'd add this to what's new in 3.14.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
iritkatriel
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We supported multi-line input in pdb in 3.13, but the tab indentation does not work in its best shape. It inserts a \t character, which means the first <tab> will introduce a 2-space (at least looks like it) indentation, and the next ones will introduce a 8-space one.
This PR made it a bit smarter. Now a <tab> at the beginning of the line (before any non-space text) will auto-fill a 4-space indentation. For example, \t and \t will both create a 4-space indentation.
This is not the smartest feature, it's not as good as pyrepl where the indentation is inserted when a new line is created. However, I think it's much better than what we have now.
The ultimate goal is to use pyrepl for pdb, so I don't think duplication too much code to make pdb work slightly better now is that rewarding.