FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-128041: Add `terminate_workers` and `kill_workers` methods to ProcessPoolExecutor by csm10495 · Pull Request #130849 · python/cpython · GitHub

Repository navigation

gh-128041: Add terminate_workers and kill_workers methods to ProcessPoolExecutor - #130849

Merged
gpshead merged 6 commits into
python:mainfrom
csm10495:gh-128041-v2
Mar 5, 2025
Merged

gpshead merged 6 commits into
python:mainfrom
csm10495:gh-128041-v2

Conversation

csm10495 commented Mar 4, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Provides a way to forcefully stop all the workers in the pool

Typically this would be used as a last effort to stop all workers if unable to shutdown / join in the expected way.

This is a newer version of #128043 that includes fixes for transient issues seen in CI.


📚 Documentation preview 📚: https://cpython-previews--130849.org.readthedocs.build/

…o ProcessPoolExecutor

Add some fixes to tests to make them no longer transient
gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit ec7599c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130849%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 4, 2025

csm10495 commented Mar 4, 2025

Copy link
Copy Markdown
Contributor Author

I've run

./python.exe -m test test.test_concurrent_futures.test_process_pool  -vvv --fail-env-changed

75 times in a row now without a failure. @colesbury mind checking again. Thanks for the feedback!

csm10495 requested a review from colesbury March 4, 2025 18:59
colesbury added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 92a2d72 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130849%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 4, 2025

colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @csm10495, this looks good to me!

I rescheduled the buildbots and I'm also running some stress tests locally. So far, it looks good!

csm10495 commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

I don't think those buildbot failures are related, but not 100% sure.

gpshead merged commit ba05a4e into python:main Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL