`test_keywords` in `test_popen` can be improved · Issue #131234 · python/cpython · GitHub

Bug report

test_keywords here:

Lines 65 to 68 in 7fd6160

    
           def test_keywords(self): 
        
               with os.popen(cmd="exit 0", mode="w", buffering=-1): 
        
                   pass

does not assert anything. I propose to use an example similar to this one:

cpython/Lib/test/test_popen.py

Lines 57 to 59 in 7fd6160

    
           def test_contextmanager(self): 
        
               with os.popen("echo hello") as f: 
        
                   self.assertEqual(f.read(), "hello\n")

and at least assert that the expected program executed and that f is still not closed in with body.

I have a PR ready.

Linked PRs

pythongh-131234: Improve `test_popen` with more asserts

gh-131234: Improve `test_popen` with more asserts (#131235)

pythongh-131234: Improve `test_popen` with more asserts (pythonGH-131235

[3.12] gh-131234: Improve `test_popen` with more asserts (GH-131235) (#…

[3.13] gh-131234: Improve `test_popen` with more asserts (GH-131235) (#…

[3.12] pythongh-131234: Improve `test_popen` with more asserts (pytho…

pythongh-131234: Improve `test_popen` with more asserts (python#131235)

`test_keywords` in `test_popen` can be improved · Issue #131234 · python/cpython · GitHub

Repository navigation

test_keywords in test_popen can be improved #131234

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	def test_keywords(self):
	with os.popen(cmd="exit 0", mode="w", buffering=-1):
	pass

	def test_contextmanager(self):
	with os.popen("echo hello") as f:
	self.assertEqual(f.read(), "hello\n")

`test_keywords` in `test_popen` can be improved · Issue #131234 · python/cpython · GitHub

Repository navigation

test_keywords in test_popen can be improved #131234

Description

Bug report

Linked PRs

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions