Quoting @picnixz: #131343 (comment)
We could add more 0-size bytes tests in other functions as well I think. For instance PyBytes_FromObject(b'') is not tested.
PRs are welcome!
Can I work on this?
@CHB-0r1s sure, please go ahead! ❤
gh-131357: Add a set of asserts to test.test_capi.test_bytearray (#13…
pythongh-131357: Add a set of asserts to test.test_capi.test_bytearray (
[3.13] gh-131357: Add a set of asserts to test.test_capi.test_bytearr…
[3.12] gh-131357: Add a set of asserts to test.test_capi.test_bytearr…
gh-131357: Add tests for zero-sized bytes objects in test_bytes.py (#…
Looks ready to close
@vstinner / @sobolevn is this an "ongoing more PRs to be made" issue or ready to close with the recently merged PRs?
[3.14] gh-131357: Add tests for zero-sized bytes objects in test_byte…
@vstinner Please take a look - #134458
Merge branch 'main' into pythongh-131357-some-extra-tests-for-empty-b…
gh-131357: Add some extra tests for empty bytes and bytearray (#134458)
pythongh-131357: Add some extra tests for empty bytes and bytearray (p…
[3.13] gh-131357: Add some extra tests for empty bytes and bytearray (G…
[3.14] gh-131357: Add some extra tests for empty bytes and bytearray (G…
pythongh-131357: Add tests for zero-sized bytes objects in test_bytes…
Activity
CHB-0r1s commented on Mar 17, 2025
Can I work on this?
sobolevn commented on Mar 17, 2025
@CHB-0r1s sure, please go ahead! ❤
gh-131357: Add a set of asserts to test.test_capi.test_bytearray (#13…
pythongh-131357: Add a set of asserts to test.test_capi.test_bytearray (
[3.13] gh-131357: Add a set of asserts to test.test_capi.test_bytearr…
[3.12] gh-131357: Add a set of asserts to test.test_capi.test_bytearr…
gh-131357: Add tests for zero-sized bytes objects in test_bytes.py (#…
AlexKautz commented on May 20, 2025
Looks ready to close
gpshead commented on May 20, 2025
@vstinner / @sobolevn is this an "ongoing more PRs to be made" issue or ready to close with the recently merged PRs?
4 remaining items
[3.14] gh-131357: Add tests for zero-sized bytes objects in test_byte…
sergey-miryanov commented on May 21, 2025
@vstinner Please take a look - #134458
Merge branch 'main' into pythongh-131357-some-extra-tests-for-empty-b…
gh-131357: Add some extra tests for empty bytes and bytearray (#134458)
pythongh-131357: Add some extra tests for empty bytes and bytearray (p…
pythongh-131357: Add some extra tests for empty bytes and bytearray (p…
[3.13] gh-131357: Add some extra tests for empty bytes and bytearray (G…
[3.14] gh-131357: Add some extra tests for empty bytes and bytearray (G…
pythongh-131357: Add some extra tests for empty bytes and bytearray (p…
pythongh-131357: Add tests for zero-sized bytes objects in test_bytes…
pythongh-131357: Add some extra tests for empty bytes and bytearray (p…
pythongh-131357: Add tests for zero-sized bytes objects in test_bytes…
pythongh-131357: Add some extra tests for empty bytes and bytearray (p…
pythongh-131357: Add some extra tests for empty bytes and bytearray (p…