gh-113081: Highlight source code in pdb - #133355
Merged
ambv merged 5 commits intoMay 5, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Open
tomasr8
reviewed
May 3, 2025
Comment thread
Lib/pdb.py
Copy link
Copy Markdown
Member
Author
|
Hi @ambv , I know it's kind of last minute feature, but I do think it is very cool to syntax-highlight the code in pdb. You are super familiar with the colorization part and I'm just using the existing interface (I hope it's correct). Could you take a look at it? Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Excellent, I was thinking that you might want to do that. Looks great! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #131507, we have some convenient interface to colorize a piece of code. We are so close to beta freeze so I'm not trying to achieve some full colorization on pdb. This PR introduces the most essential and simple piece - static source code. Basically it only colorizes source code display like ll, l, source, where and the initial stack entry display. I think the ROI is great here.
To make it safe for debuggers based on pdb, this uses the same mechanism as backend - default to False, and only enabled when pdb is explicitly brought up by breakpoint() or python -m pdb. The debuggers that inherit pdb won't be affected.
The double protection from if self.colorize is intentional - we don't know what could happen in the future so I used it for both _colorize_code and in the functions that call it.
📚 Documentation preview 📚: https://cpython-previews--133355.org.readthedocs.build/