FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133610: Remove PyUnicode_AsDecoded/Encoded functions by StanFromIreland · Pull Request #133612 · python/cpython · GitHub

Repository navigation

gh-133610: Remove PyUnicode_AsDecoded/Encoded functions - #133612

Merged
vstinner merged 8 commits into
python:mainfrom
StanFromIreland:rem-depr-uni-c-api
May 9, 2025
Merged

vstinner merged 8 commits into
python:mainfrom
StanFromIreland:rem-depr-uni-c-api

Conversation

StanFromIreland commented May 7, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

StanFromIreland requested a review from encukou as a code owner May 7, 2025 20:21
StanFromIreland changed the title Remove PyUnicode_AsDecoded/Encoded functions gh-133610: Remove PyUnicode_AsDecoded/Encoded functions May 7, 2025

StanFromIreland commented May 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member Author

Request: @vstinner

Comment thread Doc/whatsnew/3.15.rst
StanFromIreland requested a review from vstinner May 8, 2025 15:02
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment thread .editorconfig Outdated

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner commented May 9, 2025

Copy link
Copy Markdown
Member

Tests / Ubuntu (free-threading) / build and test (ubuntu-24.04) (pull_request)

test_zstd crash:

0:12:55 load avg: 14.73 [1/3/1] test_zstd worker non-zero exit code (Exit code -11 (SIGSEGV))
Re-running test_zstd in verbose mode (matching: test_compress_locking)
test_compress_locking (test.test_zstd.FreeThreadingMethodTests.test_compress_locking) ...

Fatal Python error: Fatal Python error: Segmentation faultSegmentation fault

vstinner commented May 9, 2025

Copy link
Copy Markdown
Member

A code search on PyPI top 8,000 projects found 2 projects, but there are only references to these 4 removed functions, these functions are not actually used. So we should be good in terms of impact.

vstinner merged commit 4fd1095 into python:main May 9, 2025
StanFromIreland deleted the rem-depr-uni-c-api branch May 9, 2025 15:33

emmatyping commented May 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@vstinner @StanFromIreland the zstd crash is noted in #132983 (comment). I'm still trying to figure out the cause/fix for it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL