| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Sorry, something went wrong.
There was a problem hiding this comment.
I do not think this change is correct, it is not officially registered with IANA as required.
Sorry, something went wrong.
Thanks for the review, @StanFromIreland! I updated this PR to add the extension to common_types like you suggested |
Sorry, something went wrong.
|
IANA says .cjs is an extension for the application/node type for CommonJS modules, not text/javascript: https://www.iana.org/assignments/media-types/application/node
And this makes no mention of the MIME type. |
Sorry, something went wrong.
|
Thanks for the update. And because this is actually registered with IANA, we can put it in the regular list. Please also don't force push in this repo, it makes it a bit harder to review changes. We squash merge anyway at the end. |
Sorry, something went wrong.
|
@hugovk That's a good point about force-pushing. Thank you for your help! |
Sorry, something went wrong.
There was a problem hiding this comment.
Please add to the first in the mimetypes list at https://docs.python.org/3.15/whatsnew/3.15.html#mimetypes
Sorry, something went wrong.
Adds .cjs mimetype of `text/javascript` for CommonJS modules to common_types. See here for more information: https://nodejs.org/api/modules.html#enabling
…e-140942.GYns6n.rst Add changes to news entry from code review Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Reminder about these things :)
|
Sorry, something went wrong.
|
@hugovk Oh, weird, I think my local repo had an issue because I checked out with a depth of 1 and git fetch wasn't working. I've got that sorted now and can push from my local branch normally. Thanks for your patience! |
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
Updates MIME types with .cjs type of application/node for CommonJS modules. See here for more information: https://www.iana.org/assignments/media-types/application/node
Fixes #140942